Cache binary encoding in ProcessorInstructionDeclaration

This commit caches encoding bitvector in ProcessorInstructionDeclaration instead of creating it on demand. This change speeds up decoding of ~170 instructions from ~35secs to ~15 secs (which is still appalling).
shingarov · Sep 4, 2024 · 5ec65b7 · 5ec65b7
1 parent 790dbe3
commit 5ec65b7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/ArchC-Core/ProcessorInstruction.class.st b/src/ArchC-Core/ProcessorInstruction.class.st
@@ -6,9 +6,6 @@ When the PDL spec is initially parsed, the ""instrictions"" Dictionary is filled
 Class {
 	#name : #ProcessorInstruction,
 	#superclass : #ProcessorInstructionDeclaration,
-	#instVars : [
-		'binaryEncoding'
-	],
 	#category : #'ArchC-Core-Core'
 }
 

diff --git a/src/ArchC-Core/ProcessorInstructionDeclaration.class.st b/src/ArchC-Core/ProcessorInstructionDeclaration.class.st
@@ -12,7 +12,8 @@ Class {
 		'format',
 		'internalBindings',
 		'syntax',
-		'isa'
+		'isa',
+		'binaryEncoding'
 	],
 	#classVars : [
 		'EmptyBindings'
@@ -132,7 +133,10 @@ ProcessorInstructionDeclaration >> assertInvariants [
 
 { #category : #accessing }
 ProcessorInstructionDeclaration >> binaryEncoding [
-	^format binaryEncoding inEnvironment: internalBindings
+	binaryEncoding isNil ifTrue: [
+		binaryEncoding := format binaryEncoding inEnvironment: internalBindings.
+	].
+	^ binaryEncoding
 ]
 
 { #category : #accessing }