Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Move language support #29

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

hariria
Copy link
Contributor

@hariria hariria commented Feb 3, 2024

Description

  • Adding language support for move, a smart contract language for several L1 blockchains.
  • Added a smart contract category for languages

Test

pnpm run fetch && pnpm run play

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for textmate-grammars-themes ready!

Name Link
🔨 Latest commit beae176
🔍 Latest deploy log https://app.netlify.com/sites/textmate-grammars-themes/deploys/65c67cb69ce5780008f4f884
😎 Deploy Preview https://deploy-preview-29--textmate-grammars-themes.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu
Copy link
Member

antfu commented Feb 3, 2024

https://github.com/move-language/move Seems to be inactive for 6 months, while https://github.com/pontem-network/vscode-move-ide is inactive for 3 years and even archived.

Is Move the language still active?

@hariria
Copy link
Contributor Author

hariria commented Feb 3, 2024

Sorry, I was linking to the wrong grammar reference. I updated it, this is the correct one: https://github.com/damirka/move-syntax.

The Move language is definitely still active. The Aptos blockchain is a prime example. It's also officially supported on GH as a language (github-linguist/linguist#5955).

@antfu
Copy link
Member

antfu commented Feb 5, 2024

I am not sure about the smart contract category - I don't think it's general enough to be a category. Could we focus on adding the language in this PR first and discuss the categories later?

@hariria
Copy link
Contributor Author

hariria commented Feb 5, 2024

Sure no problem!

@hariria
Copy link
Contributor Author

hariria commented Feb 5, 2024

@antfu lmk how it looks!

sources-grammars.ts Outdated Show resolved Hide resolved
@hariria
Copy link
Contributor Author

hariria commented Feb 6, 2024

Cc @antfu i think it should be g2g now

@hariria
Copy link
Contributor Author

hariria commented Feb 7, 2024

@antfu lmk if this looks good to you now! i removed the .mv alias

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antfu
Copy link
Member

antfu commented Feb 8, 2024

Please avoid pinging, we will get PRs reviewed in orders. I keep the pinging feature enabled for emergency use. Thanks.

@hariria
Copy link
Contributor Author

hariria commented Feb 9, 2024

Sorry for the pinging, thanks for the update, I've gone ahead and changed the example

@hariria hariria requested a review from antfu February 9, 2024 19:28
@antfu antfu changed the title [move] Move language support feat: add Move language support Feb 11, 2024
@antfu antfu merged commit ae8c1a1 into shikijs:main Feb 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants