Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[languages] Move path.resolve() for better static analysis #50

Merged
merged 1 commit into from
Jul 30, 2020
Merged

[languages] Move path.resolve() for better static analysis #50

merged 1 commit into from
Jul 30, 2020

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Jul 29, 2020 •
edited
Loading

This moves the path.resolve() in place so that static analysis tools such as webpack and node-file-trace can determine that the assets in ../data/grammars should be bundled.

Fixes https://twitter.com/browniefed/status/1288502416732614656

@styfle styfle changed the title Move path.resolve() for better static analysis [languages] Move path.resolve() for better static analysis Jul 29, 2020
@octref
Copy link
Collaborator

octref commented Jul 30, 2020

Thanks for keeping an eye on the twitter-bug-tracker 👀
Glad you made webpack work for you.

@octref octref merged commit fd84d55 into shikijs:master Jul 30, 2020
@styfle styfle deleted the patch-1 branch July 30, 2020 14:58
antfu added a commit that referenced this pull request Jan 26, 2024
@antfu
fix(core): getHighlighter type inference, close #50
f6060ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@styfle @octref