Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: Additional languages #102

Merged
merged 8 commits into from
Apr 6, 2021
Merged

ADD: Additional languages #102

merged 8 commits into from
Apr 6, 2021

Conversation

VladimirMikulic
Copy link
Contributor

Languages added:

  • Apache
  • Verilog
  • System Verilog
  • VHDL
  • Solidity
  • RISC-V
  • Gherkin (feature.tmLanguage)
  • Nginx
  • Nim
  • Twig

@octref
Copy link
Collaborator

octref commented Apr 3, 2021

You need to run yarn update:grammars. I'm fine for adding other grammars, but I'm not sure about Gherkin. I can't even find much documentation on it.

@VladimirMikulic
Copy link
Contributor Author

@octref Gherkin is a language for behavioural testing, but it's not that significant - removed. Appreciate the review!

VladimirMikulic and others added 6 commits April 6, 2021 12:08
@VladimirMikulic @octref
ADD: Additional languages
239f161 
Languages added:
 - Apache
 - Verilog
 - System Verilog
 - VHDL
 - Solidity
 - RISC-V
 - Gherkin (feature.tmLanguage)
 - Nginx
 - Nim
 - Twig
@octref
run update scripts
fc4577a
@VladimirMikulic @octref
Delete gherkin.tmLanguage.json
109b5f8
@VladimirMikulic @octref
Update languages.md
41db34b
@VladimirMikulic @octref
Update languages.ts
5859858
@octref
rerun update grammar scripts
8a52327
@octref
Copy link
Collaborator

octref commented Apr 6, 2021

I did a refactor of the pulling scripts, so future contributions should be easier. I rebased your changes.

re Gherkin — it seems this repo https://github.com/alexkrechik/VSCucumberAutoComplete is quite popular, so I guess I should include it. highlight.js also has it.

I also gave some languages simpler ids, for example twig instead of html-twig, etc. If you have no objections to the IDs, I'll merge your changes.
This is a great list. Thanks for helping out!

@VladimirMikulic
Copy link
Contributor Author

Awesome, thank you @octref. I've also resolved merge conflicts and we are good to go now.

@VladimirMikulic
Copy link
Contributor Author

VladimirMikulic commented Apr 6, 2021 •
edited
Loading

Hmm, heap out of memory... Unable to reproduce locally. Could it be related to the recent refactor/actions memory configuration @octref?

@octref
Copy link
Collaborator

octref commented Apr 6, 2021

Might be this, I'm not sure: jestjs/jest#9980

@octref
Copy link
Collaborator

octref commented Apr 6, 2021

Seems all good now. Thanks for your work!

@octref octref merged commit 6b99add into shikijs:master Apr 6, 2021
@VladimirMikulic
Copy link
Contributor Author

Awesome! Thank you!

@sambacha sambacha mentioned this pull request Apr 14, 2021
Closed
antfu pushed a commit that referenced this pull request Jan 26, 2024
@jxom
chore(twoslash)!: fix highlight typos (#102)
b8c4c88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladimirMikulic @octref