You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
Describe the bug
In XML formatting, git removals ([!code --]) are not displayed correctly.
Technical Problem:
In the transformerNotationDiff transformer, removals are notated with [!code --] inside of a comment. In XML, comments cannot have -- in them due to compatibility reasons, as described here:
[Definition: Comments may appear anywhere in a document outside other markup; in addition, they may appear within the document type declaration at places allowed by the grammar. They are not part of the document's character data; an XML processor MAY, but need not, make it possible for an application to retrieve the text of comments. For compatibility, the string " -- " (double-hyphen) MUST NOT occur within comments.] Parameter entity references MUST NOT be recognized within comments.
* Fix incorrect commenting on XML code blocks for shiki transformers
* Add another example for publicizing assemblies
* Added a temporary shiki transformer for XML removal diffs
Issue here: shikijs/shiki#928
* Change `--` to the new temp. transformer (`rm`)
Validations
Describe the bug
In XML formatting, git removals (
[!code --]
) are not displayed correctly.Technical Problem:
In the
transformerNotationDiff
transformer, removals are notated with[!code --]
inside of a comment. In XML, comments cannot have--
in them due to compatibility reasons, as described here:https://www.w3.org/TR/REC-xml/#sec-comments
Reproduction
Contributes
The text was updated successfully, but these errors were encountered: