-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong HTML escape sequences in demo #63
Comments
This bug might be introduced from #59. |
See lodash/escape. Instead of escaping these charactors in several passes(which is buggy), we should escape all these charactors at the same time. |
closes shikijs#63, and makes the process done in one pass. Thanks to @Enter-tainer 's suggestions.
Do we only escape HTML code snippets? I am using the vuepress plugin and found
without specifying any language id, produces a result (visually) like this
|
We escape HTML output. |
Then am I missing any configuration? GitHub https://github.com/yzhang-gh/notes/blob/vuepress/docs/programming/python/miniconda.md#managing-environments Vuepress https://yzhang-gh.github.io/notes/programming/python/miniconda.html#managing-environments I can confirm Shiki works as expected elsewhere. |
Please provide a reproducible case with reproducing steps. |
Here you go (#93). |
It seems that the implementation of html escape is wrong.
It firstly converts
>
to>
, then converts>
to&gt
, which is not what we expected.I suggest checking out the implementation of lodash.
The text was updated successfully, but these errors were encountered: