-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect snap installation of Visual Studio Code on Linux #156
Conversation
Not sure I understand why the linux build is failing... |
Can you try that? Just swapping the directories. I don't know how it works but it's the only thing that seems affecting the process and not being backward compatible. edit: except if you really need that match first with snap, in that case my changes are useless. Also you check this out? |
@ziggy42 I don't believe it's related to the PR. I'll investigate this when I have a spare moment. |
@LuKks the order of these paths should only matter if you have both installed. Something needs to be chosen, and a pattern that's good to go with here is something like:
I don't have strong feelings on what order we should use here, just that we choose something and try to stick to it... |
0f3f7f2
to
984a08d
Compare
Closes #155
Description
Allows Visual Studio Code and Visual Studio Code Insiders to be detected as external editors when installed as snaps
Release notes
Notes: detect Visual Studio Code and Visual Studio Code Insiders as external editors when installed as snaps