Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect snap installation of Visual Studio Code on Linux #156

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Detect snap installation of Visual Studio Code on Linux #156

merged 2 commits into from
Jul 2, 2019

Conversation

ziggy42
Copy link

@ziggy42 ziggy42 commented Jun 18, 2019

Closes #155

Description

Allows Visual Studio Code and Visual Studio Code Insiders to be detected as external editors when installed as snaps

Release notes

Notes: detect Visual Studio Code and Visual Studio Code Insiders as external editors when installed as snaps

@ziggy42
Copy link
Author

ziggy42 commented Jun 19, 2019

Not sure I understand why the linux build is failing...

@LuKks
Copy link

LuKks commented Jun 19, 2019

Can you try that? Just swapping the directories. I don't know how it works but it's the only thing that seems affecting the process and not being backward compatible.

edit: except if you really need that match first with snap, in that case my changes are useless.

Also you check this out?
https://brendanforster.visualstudio.com/desktop-linux/_build/results?buildId=385
Linux -> Package in Container

@shiftkey
Copy link
Owner

Not sure I understand why the linux build is failing...

@ziggy42 I don't believe it's related to the PR. I'll investigate this when I have a spare moment.

@shiftkey
Copy link
Owner

shiftkey commented Jun 19, 2019

Can you try that? Just swapping the directories. I don't know how it works but it's the only thing that seems affecting the process and not being backward compatible.

@LuKks the order of these paths should only matter if you have both installed. Something needs to be chosen, and a pattern that's good to go with here is something like:

  • when multiple versions are found, favour the latest version
  • when multiple installations found of the same version, favour the one that's more specific to the user

I don't have strong feelings on what order we should use here, just that we choose something and try to stick to it...

@shiftkey shiftkey merged commit 6476bcc into shiftkey:linux Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editors installed via snap are not detected
3 participants