Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Desktop doesn't recognise atom as being installed on the machine #147

Closed
astrolemonade opened this issue May 8, 2019 · 4 comments

Comments

@astrolemonade
Copy link

astrolemonade commented May 8, 2019

When I want to open a repo in an external editor from within the Github Desktop app a notification is telling me I need to install Atom, even if I have it installed already.
I tried to change the settings in the preferences, but no success.
Note: Atom editor was not installed from flatpak

@shiftkey
Copy link
Owner

shiftkey commented May 8, 2019

@cata0309 please tell me which version/installer of Desktop you're using, and where Atom was installed to.

The app is looking at this location, and I'm not sure if we need to do additional checks if there are other standard locations:

case ExternalEditor.Atom:
return getPathIfAvailable('/usr/bin/atom')

@astrolemonade
Copy link
Author

I understand, that was my problem, I had it installed from snap, but after I installed from their site all good.It is recognisable now

@tsutterley
Copy link

I know this issue is closed, but something similar to the following in linux.ts might fix it for future releases
return getFirstPathIfAvailable(['/snap/bin/atom', '/usr/bin/atom'])
(not that a symbolic link from the snap install location doesn't work)

@shiftkey
Copy link
Owner

@tsutterley if someone wanted to PR that change in I'd be happy to review it

tsutterley added a commit to tsutterley/desktop that referenced this issue Sep 13, 2019
shiftkey pushed a commit to tsutterley/desktop that referenced this issue Oct 14, 2019
shiftkey pushed a commit that referenced this issue Oct 14, 2019
shiftkey pushed a commit that referenced this issue Feb 4, 2020
shiftkey pushed a commit that referenced this issue Feb 6, 2020
shiftkey pushed a commit that referenced this issue Feb 6, 2020
shiftkey pushed a commit that referenced this issue Feb 6, 2020
shiftkey pushed a commit that referenced this issue Feb 6, 2020
shiftkey pushed a commit that referenced this issue Feb 6, 2020
shiftkey pushed a commit that referenced this issue Feb 7, 2020
shiftkey pushed a commit that referenced this issue Feb 7, 2020
shiftkey pushed a commit that referenced this issue Feb 7, 2020
shiftkey pushed a commit that referenced this issue Feb 7, 2020
shiftkey pushed a commit that referenced this issue Feb 7, 2020
shiftkey pushed a commit that referenced this issue Feb 18, 2020
shiftkey pushed a commit that referenced this issue Feb 21, 2020
shiftkey pushed a commit that referenced this issue Mar 2, 2020
shiftkey pushed a commit that referenced this issue Mar 11, 2020
shiftkey pushed a commit that referenced this issue Mar 20, 2020
shiftkey pushed a commit that referenced this issue Mar 26, 2020
shiftkey pushed a commit that referenced this issue Mar 26, 2020
shiftkey pushed a commit that referenced this issue Mar 26, 2020
shiftkey pushed a commit that referenced this issue Apr 2, 2020
shiftkey pushed a commit that referenced this issue Apr 6, 2020
shiftkey pushed a commit that referenced this issue Jul 2, 2020
shiftkey pushed a commit that referenced this issue Jul 3, 2020
shiftkey pushed a commit that referenced this issue Jul 10, 2020
shiftkey pushed a commit that referenced this issue Aug 19, 2020
shiftkey pushed a commit that referenced this issue Aug 24, 2020
shiftkey pushed a commit that referenced this issue Aug 25, 2020
shiftkey pushed a commit that referenced this issue Aug 27, 2020
shiftkey pushed a commit that referenced this issue Aug 27, 2020
shiftkey pushed a commit that referenced this issue Aug 27, 2020
shiftkey pushed a commit that referenced this issue Nov 6, 2020
shiftkey pushed a commit that referenced this issue Nov 6, 2020
shiftkey pushed a commit that referenced this issue Nov 6, 2020
shiftkey pushed a commit that referenced this issue Nov 6, 2020
shiftkey pushed a commit that referenced this issue Nov 6, 2020
shiftkey pushed a commit that referenced this issue Nov 6, 2020
shiftkey pushed a commit that referenced this issue Nov 6, 2020
shiftkey pushed a commit that referenced this issue Nov 6, 2020
shiftkey pushed a commit that referenced this issue Nov 11, 2020
shiftkey pushed a commit that referenced this issue Dec 11, 2020
shiftkey pushed a commit that referenced this issue Dec 17, 2020
shiftkey pushed a commit that referenced this issue Dec 17, 2020
shiftkey pushed a commit that referenced this issue Dec 17, 2020
shiftkey pushed a commit that referenced this issue Dec 17, 2020
shiftkey pushed a commit that referenced this issue Dec 17, 2020
shiftkey pushed a commit that referenced this issue Dec 18, 2020
shiftkey pushed a commit that referenced this issue Dec 18, 2020
shiftkey pushed a commit that referenced this issue Dec 27, 2020
shiftkey pushed a commit that referenced this issue Jan 23, 2021
shiftkey pushed a commit that referenced this issue Jan 23, 2021
shiftkey pushed a commit that referenced this issue Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants