Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Number System readme.md #721

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

Ettubrute05
Copy link
Contributor

Proposed changes

Fixed markdown formatting for clarity and readability.
Modified charts for better readability.
Edited some explanations to match chart changes and for clarity.
Fixed table of contents and section title links so they work.
Fixed file name for lua example so the link to it works.
Fixed minor spelling errors.

Types of changes

What types of changes does your content introduce to this project?
Put an x in the boxes that apply (without "`")

  • Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
  • New content (new section, new readme, etc.)
  • Modifications (modifying existing content)
  • [ ] Other (please describe)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This simply reminds us of what we will look for before merging your code.
Note: If you submit code make sure to test it

  • Tested any code that was added/modified in this PR
  • Added external links
  • Added internal links
  • Added images
  • Added videos
  • Added code snippets

Further comments

The changes are pretty straightforward.

Adding your name to the contributor's list

Comment "@all-contributors please add @your_username for content" to add your name to the contributor's list.
You can change the "content" with any of this

Reviewers:

  • @username

Please ensure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information.

Fixed markdown formatting for clarity and readability.
Modified charts for better readability.
Edited some explanations to match chart changes and for clarity.
Fixed table of contents and section title links so they work.
Fixed file name for lua example so the link to it works.
Fixed minor spelling errors.
@the-label-bot the-label-bot bot added kind/documentation kind/documentation size/L size/L labels Nov 6, 2023
Copy link

the-label-bot bot commented Nov 6, 2023

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind documentation 0.999 ✔️
Size L 0.935 ✔️

Copy link
Owner

@shhossain shhossain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late update.

@shhossain shhossain merged commit d58e5d8 into shhossain:main Nov 27, 2023
1 check failed
@shhossain
Copy link
Owner

@all-contributors add @Ettubrute05 for content and code.

Copy link
Contributor

@shhossain

I've put up a pull request to add @Ettubrute05! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation kind/documentation size/L size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants