Return response from SnappPay::eligible #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all SnappPay endpoints except
/oauth/token
have a specific JSON structure in their response as below:The SnappPay driver implemented in this project has followed this structure and is checking the
successful
boolean property first (throwing an exception if it's false), then returning theresponse
property as result in all public methods. But this convention has been ignored in theeligible
method. Thesuccessful
property check is absent, and it's returning the entire json body instead of theresponse
property.I submitted this PR to follow the same convention for returning results in all public methods. I am aware that this change may introduce a breaking change, so please let me know how you handle these kind of inconsistencies.