Update Angular 6 #328
Update Angular 6 #328
Conversation
lib/src/modal/modal.component.ts
Outdated
| @@ -23,7 +23,7 @@ export class MzModalComponent extends HandlePropChanges implements OnInit, After | |||
| @Input() fixedFooter: boolean; | |||
| @Input() fullscreen: boolean; | |||
| @Input() options: Materialize.ModalOptions; | |||
| @Output() onClose = new EventEmitter<void>(); | |||
| @Output() onClose = new EventEmitter<void>(); // tslint:disable-line:no-output-on-prefix | |||
There was a problem hiding this comment.
We should rename this in future release lol.
There was a problem hiding this comment.
you're right ... since we are going to do a major maybe doing it now would be the good time
There was a problem hiding this comment.
You should also see the select component. I think this one had onChange ouput attribute.
There was a problem hiding this comment.
I'll search everywhere i've disabled tslint ... I forgot to add this to my huuuuge list of things to do :) But some are @Input() properties that matches the name of the option in Materialize intialization.
package.json
Outdated
| "@angular/router": "^6.0.0", | ||
| "core-js": "^2.5.4", | ||
| "highlightjs": "^9.10.0", | ||
| "mdi": "^1.8.36", |
There was a problem hiding this comment.
We could use @mdi/font instead of mdi .
There was a problem hiding this comment.
alright i'll do it, i'll update the doc at the same time
✔️ Ready to be reviewed/merged
disable:no-output-on-prefixand fix the issues correctlymdilibrary in demo for@mdi/fontand update README.md icon installation instructionsFix #316
ngx-materialize v6.0.0
📦 Respository renamed from
ng2-materializetongx-materialize🆖️ Updated to Angular 6
🚀 Version bumped to
6.0.0Breaking changes
Repository renamed
ng2-materializeand installngx-materializeMzModal component
onCloseoutput property has been renamed tocloseopenexposed method has been renamed toopenModalcloseexposed method has been renamed tocloseModalMzSelect directive
onUpdateoutput property has been renamed toupdate