Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

Add Sidenav opened state #227

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Add Sidenav opened state #227

merged 3 commits into from
Oct 30, 2017

Conversation

jfcere
Copy link
Contributor

@jfcere jfcere commented Oct 21, 2017

✔️ Ready to be reviewed/merged

  • Allow Sidenav to be open/close through opened state
  • Adjust demo page
  • Fix unit/view tests
  • Add unit/view tests

Fixes #208, #215

@scote scote self-assigned this Oct 30, 2017
// Initialize collapsible button for side navigation
$(collapseButton).sideNav(<any>{
// initialize sidenav
this.collapseButton.sideNav(<any>{
Copy link
Contributor

@scote scote Oct 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should use SideNavOptions interface for the type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do another PR .. this has nothing to do with my changes

scote
scote previously approved these changes Oct 30, 2017
@scote scote dismissed their stale review October 30, 2017 14:33

Need one change

@scote scote merged commit e14a278 into master Oct 30, 2017
@scote scote deleted the sidenav-state branch October 30, 2017 14:49
@jfcere jfcere added this to the 1.7.0 milestone Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can close sidenav when clicking of close button in the menu?
2 participants