This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Update readme "Why ng2-materialize?" section #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfcere
reviewed
Oct 31, 2017
README.md
Outdated
|
|
||
| We already know the possibilities Materialize offers. What is left to do is to wrap components that we want to use in Angular component. | ||
| ### Initialization simplified |
There was a problem hiding this comment.
I think its a bit heavy for a read-me file (TLDR) ... what do you think about only mentioning those with bullet points? Something like ...
In other words, we ...
- Simplify components initialization
- Handle Angular "quirks" with Materialize library
- Offer component injection when possible
- Provide a MediaService that allow customization according to view port size
- Added support for ReactiveForm with validation
There was a problem hiding this comment.
Pretty good and it's a good resume to what we try to do.
jfcere
reviewed
Oct 31, 2017
README.md
Outdated
| Another nice advantage that we added to our implementation is the Form Validation. Materialize only provide HTML5 validation while we added support for Reactive Form allowing a more flexible way to do form validation following the same Material Design guidelines. | ||
| In other words, we ... | ||
|
|
||
| - Simplify component usage |
jfcere
approved these changes
Nov 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.