-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic text and label properties for buttons #1815
Conversation
Hi @radibit, thanks for the PR! This is definitely a useful feature. Would you mind also updating the docs to mention these things can now be functions and how to use them, etc? |
@rwwagner90 Thank you for the quick response. I'll update the docs, good reminder 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks for making those changes and thanks for the PR.
Hey @rwwagner90 sorry to bother you but can I ask if there is a release in planning for the next version of Shepherd library which will include the change completed with this PR? ℹ️ Unfortunately, there isn't a way to point in my |
@radibit I released the other day. Sorry for the delay! |
Hey folks 👋
This PR:
text
andlabel
properties for thebutton
componentbutton
component (getConfigOption
function)button
unit testsStepOptionsButton
interfaceusage
docs with the new info about thebutton
componentThe common case for dynamic text and label button properties is when
Shepherd
is used with an i18n (internationalization) solution and those fields need to be updated on change of the language settings. That has been already in place for the main text component but was missing for the buttons.