Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Purifier Humidify+Cool Formaldehyde #19

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Conversation

vwt12eh8
Copy link
Contributor

The following support has been added.
https://www.dyson.com/air-treatment/air-purifier-humidifiers/purifier-humidify-cool-formaldehyde-ph04

Device type is 358E.
It extends from the already implemented "device type 358".
Supports the acquisition of formaldehyde sensor values.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #19 (5b5ff41) into main (e52f4da) will decrease coverage by 0.20%.
The diff coverage is 75.00%.

❗ Current head 5b5ff41 differs from pull request most recent head dd4ff48. Consider uploading reports for the commit dd4ff48 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   99.04%   98.84%   -0.21%     
==========================================
  Files          21       21              
  Lines         944      951       +7     
==========================================
+ Hits          935      940       +5     
- Misses          9       11       +2     
Impacted Files Coverage Δ
libdyson/__init__.py 97.61% <66.66%> (-2.39%) ⬇️
libdyson/dyson_pure_humidify_cool.py 98.18% <75.00%> (-1.82%) ⬇️
libdyson/const.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52f4da...dd4ff48. Read the comment docs.

libdyson/__init__.py Show resolved Hide resolved
@Kakise Kakise merged commit 7b19d1c into shenxn:main Nov 29, 2021
@Kakise
Copy link
Collaborator

Kakise commented Nov 29, 2021

LGTM ! thanks for your contribution ! :) It will be available around this weekend alongside 0.16.1 release

@vwt12eh8 vwt12eh8 deleted the ph04 branch November 29, 2021 10:53
@austinbeam
Copy link

This device type also applies to the PH03 Model, one of which I received as a warranty replacement for my PH01. Is there any update @Kakise on when this commit will be included in a release? I cannot currently connect to my device with ha-dyson because the device type is not supported in libdyson.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants