fix #83

shenwei356 · Aug 14, 2019 · 6693f05 · 6693f05
1 parent 39ca516
commit 6693f05
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,6 @@
+- [csvtk v0.18.3](https://github.com/shenwei356/csvtk/releases/tag/v0.18.3)
+[![Github Releases (by Release)](https://img.shields.io/github/downloads/shenwei356/csvtk/v0.18.3/total.svg)](https://github.com/shenwei356/csvtk/releases/tag/v0.18.3)
+    - `csvtk split`: fix bug of repeatedly output header line when number of output files exceed value of `--buf-groups`. [#83](https://github.com/shenwei356/csvtk/issues/83)
 - [csvtk v0.18.2](https://github.com/shenwei356/csvtk/releases/tag/v0.18.2)
 [![Github Releases (by Release)](https://img.shields.io/github/downloads/shenwei356/csvtk/v0.18.2/total.svg)](https://github.com/shenwei356/csvtk/releases/tag/v0.18.2)
     - `csvtk replace/rename2/splitxlsx`: fix flag conflicts with global flag `-I` since v0.18.0.

diff --git a/csvtk/cmd/split.go b/csvtk/cmd/split.go
@@ -334,7 +334,8 @@ func appendRows(config Config,
 	var outfh *xopen.Writer
 	var err error
 
-	if _, ok := moreThanOneWrite.Load(key); ok {
+	_, writeOnce := moreThanOneWrite.Load(key)
+	if writeOnce {
 		outfh, err = xopen.WopenFile(outFile, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
 	} else {
 		outfh, err = xopen.Wopen(outFile)
@@ -353,7 +354,7 @@ func appendRows(config Config,
 	if printMetaLine && len(csvReader.MetaLine) > 0 {
 		outfh.WriteString(fmt.Sprintf("sep=%s\n", string(writer.Comma)))
 	}
-	if headerRow != nil {
+	if !writeOnce && headerRow != nil {
 		checkError(writer.Write(headerRow))
 	}
 

diff --git a/csvtk/cmd/version.go b/csvtk/cmd/version.go
@@ -29,7 +29,7 @@ import (
 )
 
 // VERSION of csvtk
-const VERSION = "0.18.2"
+const VERSION = "0.18.3"
 
 // versionCmd represents the version command
 var versionCmd = &cobra.Command{