Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auditing fix #855

Merged
merged 3 commits into from
May 20, 2024
Merged

Auditing fix #855

merged 3 commits into from
May 20, 2024

Conversation

skyargos
Copy link
Contributor

Closes: #XXX
Related: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

@skyargos skyargos marked this pull request as ready for review May 20, 2024 07:40
@skyargos skyargos requested a review from a team as a code owner May 20, 2024 07:40
@skyargos skyargos requested review from kevin-yuhh and haozhan9 and removed request for a team May 20, 2024 07:40
@skyargos skyargos merged commit 42d6a53 into upgrade-workflows May 20, 2024
12 of 15 checks passed
@skyargos skyargos deleted the auditing-fix2 branch May 20, 2024 07:40
skyargos added a commit that referenced this pull request Jun 3, 2024
@skyargos
V2.10.0 rc1 (#861)
8935bb4 
* update to 0.45.16

* update module

* update third_party proto

* update gov module

* update gov module

* update to cosmos-sdk v0.46.13

* del test case

* update genesis validate

* legacy proposal

* remove legacy handler

* fix legacy gov module

* fix gov tally

* fix test case

* fix gov v1alpha1

* fix gov test

* upgrade workflows go version to 1.19

* fix test

* fix test unit cover

* change sdk.Int to math.Int

* fix audit: export for zero height

* upgrade workflows go version

* fix simulation

* fix e2e test

* remove binary

* fix sdkerrors

* add gov migrate

* update upgrade handler

* add auth migration

* Auditing fix (#855)

* return err when purchase does not exist

* Remove the redundant negative check.

* fix msgUpdateSponsor validationBasic

* add test case

* update ibc from v5 to v6

* fix test unit cover

* add gov event

* return err when purchase does not exist

* fix lint error

* fix lint error

* fix lint error

* fix gofmt

* add group module (#859)

* V2.10.0 rc3 (#860)

* refactor gov

* fix audit: renew shield calculation

* fix audit: GetPoolsBySponsor should use sponsor (#862)

* Add Certifier And ShieldClaim Proposal Check

* add keeper in NewLegacyMsgServerImpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-yuhh kevin-yuhh Awaiting requested review from kevin-yuhh kevin-yuhh is a code owner automatically assigned from shentufoundation/chain-team

@haozhan9 haozhan9 Awaiting requested review from haozhan9 haozhan9 is a code owner automatically assigned from shentufoundation/chain-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skyargos