Update IBC to v4.2.0 #599
Merged
Update IBC to v4.2.0 #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update cosmos-sdk to v0.45.10
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
==========================================
+ Coverage 42.47% 42.87% +0.40%
==========================================
Files 127 127
Lines 11827 11715 -112
==========================================
Hits 5023 5023
+ Misses 6324 6212 -112
Partials 480 480
|
yoongbok-lee
requested changes
Feb 9, 2023
app/upgrade_handler.go
Outdated
| app.CrisisKeeper.InitGenesis(ctx, crisisGenesis) | ||
|
|
||
| // transfer module consensus version has been bumped to 2 | ||
| fromVM[ibctransfer.ModuleName] = app.mm.Modules[ibctransfer.ModuleName].ConsensusVersion() |
There was a problem hiding this comment.
Is this correct? This will disable IBC transfer store upgrade
There was a problem hiding this comment.
emm, I have removed this
yoongbok-lee
requested changes
Feb 13, 2023
| crisisGenesis.ConstantFee.Denom = app.StakingKeeper.BondDenom(ctx) | ||
| app.CrisisKeeper.InitGenesis(ctx, crisisGenesis) | ||
|
|
||
| // transfer module consensus version has been bumped to 2 | ||
| ctx.Logger().Info("Start to run module migrations...") | ||
| newVersionMap, err := app.mm.RunMigrations(ctx, app.configurator, fromVM) |
There was a problem hiding this comment.
now we can just return this without anything else in the function body
yoongbok-lee
approved these changes
Feb 13, 2023
haozhan9
reviewed
Feb 14, 2023
| crisisGenesis.ConstantFee.Denom = app.StakingKeeper.BondDenom(ctx) | ||
| app.CrisisKeeper.InitGenesis(ctx, crisisGenesis) | ||
|
|
||
| // transfer module consensus version has been bumped to 2 |
There was a problem hiding this comment.
If this line of comment means to show all modules that are going to do upgrading, we could provide a full list of them. Or it may be better to just remove the line.
There was a problem hiding this comment.
At present, only transfer is upgraded, and other modules are not upgraded for the time being.
haozhan9
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update cosmos-sdk to v0.45.10
Closes: #XXX
Related: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)