Bump IBC version to v3 & add ICA module

[yoongbok-lee]

Closes: #XXX
Related: #XXX

Description

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]"

[xiumingdou]

Approved on condition that the conflicts are resolved

[codecov]

Codecov Report

Merging #402 (f12a3cf) into master (f104aef) will decrease coverage by 0.02%.
The diff coverage is 48.52%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   41.26%   41.24%   -0.03%     
==========================================
  Files         123      123              
  Lines       11256    11318      +62     
==========================================
+ Hits         4645     4668      +23     
- Misses       6157     6196      +39     
  Partials      454      454              

Impacted Files	Coverage Δ
app/upgrade_handler.go	6.45% <0.00%> (-8.37%)	⬇️
app/app.go	86.89% <100.00%> (+0.35%)	⬆️
x/shield/keeper/invariants.go	78.16% <0.00%> (-0.25%)	⬇️
x/shield/keeper/staking_purchase.go	14.64% <0.00%> (-0.10%)	⬇️
x/shield/keeper/purchase.go	56.80% <0.00%> (+0.64%)	⬆️
x/shield/keeper/pool.go	49.36% <0.00%> (+0.68%)	⬆️

[yoongbok-lee]

looking into the simulations failure atm

[skyargos]

Need to add a controller submodule for account registration and message sending?

[skyargos]

ICAControllerKeeper icacontrollerkeeper.Keeper

[yoongbok-lee]

no I think that's for the controller chain

[skyargos]

ibc-go v3.1.0 api-breaking

• (transfer) #675 Transfer NewKeeper now takes in an ICS4Wrapper. The ICS4Wrapper may be the IBC Channel Keeper when ICS20 is not used in a middleware stack. The ICS4Wrapper is required for applications wishing to connect middleware to ICS20.

I will add this.

[yoongbok-lee]

ibc-go v3.1.0 api-breaking

• (transfer) #675 Transfer NewKeeper now takes in an ICS4Wrapper. The ICS4Wrapper may be the IBC Channel Keeper when ICS20 is not used in a middleware stack. The ICS4Wrapper is required for applications wishing to connect middleware to ICS20.

I will add this.

Isn't that changelog for v3.1.0? we're upgrading to v3.0.0

[xiumingdou]

The go.mod shows 3.1.0

revisit

[skyargos]

Modification from 'github.com/cosmos/cosmos-sdk/simapp' to 'github.com/cosmos/ibc-go/v3/testing/simapp':

1. ModuleBasics in the simapp of cosmosSDK does not contain ica.
2. The 27-interchain-accounts module of ibc-go does not implement the AppModuleSimulation interface.
3. The simulation initialization cannot be completed in AppStateRandomizedFn of cosmosSDK, so use ibc-go instead. genesisState simManager

[skyargos]

LGTM

[yoongbok-lee]

nice catch! didn't realize they implemented simapp for IBC stuff

[yoongbok-lee]

LGTM