Skip to content

Commit

Permalink
skip empty certificate's proposer (#749)
Browse files Browse the repository at this point in the history
add v3
  • Loading branch information
kevin-yuhh committed Aug 7, 2023
1 parent 1364d46 commit 8521dbb
Showing 1 changed file with 12 additions and 8 deletions.
20 changes: 12 additions & 8 deletions x/cert/legacy/v2/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,13 @@ func migrateCertifier(store sdk.KVStore, cdc codec.BinaryCodec) error {
}

Check warning on line 84 in x/cert/legacy/v2/store.go

View check run for this annotation

Codecov / codecov/patch

x/cert/legacy/v2/store.go#L83-L84

Added lines #L83 - L84 were not covered by tests
certifier.Address = certifierAddr

proposalAddr, err := common.PrefixToShentu(certifier.Proposer)
if err != nil {
return err
if len(certifier.Proposer) != 0 {
proposalAddr, err := common.PrefixToShentu(certifier.Proposer)
if err != nil {
return err
}

Check warning on line 91 in x/cert/legacy/v2/store.go

View check run for this annotation

Codecov / codecov/patch

x/cert/legacy/v2/store.go#L90-L91

Added lines #L90 - L91 were not covered by tests
certifier.Proposer = proposalAddr
}
certifier.Proposer = proposalAddr

bz := cdc.MustMarshalLengthPrefixed(&certifier)
oldStore.Set(iterator.Key(), bz)
Expand All @@ -112,11 +114,13 @@ func migrateCertifierAlias(store sdk.KVStore, cdc codec.BinaryCodec) error {
}

Check warning on line 114 in x/cert/legacy/v2/store.go

View check run for this annotation

Codecov / codecov/patch

x/cert/legacy/v2/store.go#L113-L114

Added lines #L113 - L114 were not covered by tests
certifier.Address = certifierAddr

proposalAddr, err := common.PrefixToShentu(certifier.Proposer)
if err != nil {
return err
if len(certifier.Proposer) != 0 {
proposalAddr, err := common.PrefixToShentu(certifier.Proposer)
if err != nil {
return err
}

Check warning on line 121 in x/cert/legacy/v2/store.go

View check run for this annotation

Codecov / codecov/patch

x/cert/legacy/v2/store.go#L120-L121

Added lines #L120 - L121 were not covered by tests
certifier.Proposer = proposalAddr
}
certifier.Proposer = proposalAddr

bz := cdc.MustMarshalLengthPrefixed(&certifier)
oldStore.Set(iterator.Key(), bz)
Expand Down

0 comments on commit 8521dbb

Please sign in to comment.