fix: Selecting a group may cause selection of duplicate items (#945) #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
akki-jat
commented
Apr 19, 2019
akki-jat
commented
- Closes Selecting a group may cause selection of duplicate items #945
akki-jat
commented
Apr 19, 2019
| @@ -560,7 +560,9 @@ export default { | |||
|
|
|||
| this.$emit('input', newValue, this.id) | |||
| } else { | |||
| const optionsToAdd = group[this.groupValues].filter(not(this.isOptionDisabled || this.isSelected)) | |||
There was a problem hiding this comment.
The problem here was that not function takes a function as parameter and as the name suggests performs not operation on it's response and we were passing two functions separated by pipe as parameter so it always takes first function - isOptionDisabled (takes second function - isSelected only when first function is null / undefined - which is not the case here)
Closed
|
This looks amazing! Thanks a lot for also including a test for it. Really appreciate it. Gonna make a release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.