fix: use multiple instances at the same time #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
========================================
+ Coverage 94.31% 100% +5.68%
========================================
Files 2 2
Lines 88 87 -1
========================================
+ Hits 83 87 +4
+ Misses 5 0 -5
Continue to review full report at Codecov.
|
mastilver
force-pushed
the
fix-multiple-instances
branch
from
5969baa
to
5f83ae8
Compare
|
Regarding #100 discussion that means that's the multi instance solution that was chosen. |
|
@deguif Yeah, I really wasn't sure what was the right solution..., I think this is the most natural for the user, I hope it doesn't introduce any bugs... |
|
@mastilver Yes, I totally agree. I find it better too. But from the discussion I was ready to play with an array of config. |
|
Any news about this PR? |
mastilver
force-pushed
the
fix-multiple-instances
branch
from
5f83ae8
to
186bca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #100