feat(agent): reauthentication timeout #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiytor
force-pushed
the
feat/reconnect-timeout
branch
3 times, most recently
from
7df3b4d to
f48d9ab
Compare
heiytor
changed the title
heiytor
force-pushed
the
feat/reconnect-timeout
branch
7 times, most recently
from
4ffcf3e to
b28c6db
Compare
Currently, the agent pings ShellHub's request endpoint every 10 minutes. This can cause a flood of requests when many agents try to reconnect simultaneously. To address this, we're introducing the `MAX_RETRY_CONNECTION_TIMEOUT` environment variable. This variable sets the maximum value for a random timeout interval. The agent will now wait for the interval plus a random value (up to the maximum specified) before reauthenticating. The default value is 60 seconds.
heiytor
force-pushed
the
feat/reconnect-timeout
branch
from
b28c6db to
a850573
Compare
heiytor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the agent pings ShellHub's request endpoint every 10 minutes. This can cause a flood of requests when many agents try to reconnect simultaneously.
To address this, we're introducing the
MAX_RETRY_CONNECTION_TIMEOUTenvironment variable. This variable sets the maximum value for a random timeout interval. The agent will now wait for the interval plus a random value (up to the maximum specified) before reauthenticating.The default value is 60 seconds.