Skip to content

Commit

Permalink
adding 'curl' to base msa-api image
Browse files Browse the repository at this point in the history
Fixing readiness/liveness probes on msa-api (the app itself has no 
retries to redis....)
  • Loading branch information
Anatoly Rabkin committed Oct 11, 2018
1 parent 2368d02 commit e790152
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 23 deletions.
2 changes: 1 addition & 1 deletion charts/msa-api/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ replicaCount: 1

image:
repository: shelleg/msa-api
tag: 0.1.2
tag: 0.1.3
pullPolicy: Always

nameOverride: "msa-api"
Expand Down
10 changes: 0 additions & 10 deletions charts/msa-pinger/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,3 @@ spec:
timeoutSeconds: {{ .Values.livinessProbe.timeoutSeconds }}
periodSeconds: {{ .Values.livinessProbe.periodSeconds }}
failureThreshold: {{ .Values.livinessProbe.failureThreshold }}
# readinessProbe:
# httpGet:
# host: {{ .Release.Name }}-msa-api
# path: /isAlive
# port: 8080
# scheme: HTTP
# initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
# timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }}
# periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
# failureThreshold: {{ .Values.readinessProbe.failureThreshold }}
10 changes: 0 additions & 10 deletions charts/msa-poller/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,3 @@ spec:
timeoutSeconds: {{ .Values.livinessProbe.timeoutSeconds }}
periodSeconds: {{ .Values.livinessProbe.periodSeconds }}
failureThreshold: {{ .Values.livinessProbe.failureThreshold }}
# readinessProbe:
# httpGet:
# host: {{ .Release.Name }}-msa-api
# path: /isAlive
# port: 8080
# scheme: HTTP
# initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
# timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }}
# periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
# failureThreshold: {{ .Values.readinessProbe.failureThreshold }}
2 changes: 1 addition & 1 deletion msa-api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM shelleg/node-base-img:0.1.1
FROM shelleg/node-base-img:0.1.2

RUN mkdir -p /opt/tikal/config

Expand Down
3 changes: 2 additions & 1 deletion msa-api/Dockerfile-base
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM node:6-alpine

COPY package.json .
RUN npm install
RUN apk add --no-cache curl && \
npm install

0 comments on commit e790152

Please sign in to comment.