Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: design review by megumin-san #88

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

motoya-k
Copy link

  • modify the heading style
  • modify the list (ul and ol) style
  • modify the checkbox list style
Screen.Recording.2024-01-24.at.17.33.15.mov

margin-bottom: 1rem;
}

.novel-prose-lg :where(h1, h2, h3):not(:where([class~="novel-not-prose"] *)) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一番先頭にある Heading 以外に当てるスタイル

Copy link
Collaborator

@enokids enokids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

頂いた動画のh3の方がデカいのって大丈夫ですよね???笑

@motoya-k
Copy link
Author

ありがとうございます!

頂いた動画のh3の方がデカいのって大丈夫ですよね???笑

紛らわしくてすみません!全部h3でやっちゃってました🙇 これはh3ですといいつつ、h1やh2です笑

@motoya-k motoya-k requested a review from enokids January 24, 2024 15:50
Copy link
Collaborator

@kenfdev kenfdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenfdev kenfdev merged commit 1fc554c into she-main Jan 25, 2024
@kenfdev kenfdev deleted the feature/design-review-by-megumin-san branch January 25, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants