Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix styles #83

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: fix styles #83

merged 1 commit into from
Jan 18, 2024

Conversation

motoya-k
Copy link

slack:
https://sheinc.slack.com/archives/C02N557HFNF/p1705034179431749

全体

  • font-size: 1rem;
  • line-height: 180%;

見出し

共通

  • font-weight: 600

h1

  • font-size: 1.5rem / 24px

h2

  • font-size: 1.25rem / 20px

h3

  • font-size: 1.125rem / 18px

@@ -7,7 +7,7 @@ export const cal = localFont({
});

export const crimsonBold = Crimson_Text({
weight: "700",
weight: "600",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weight を 600 に

@@ -1,5 +1,5 @@
.ProseMirror {
@apply novel-p-12 novel-px-8 sm:novel-px-12;
@apply novel-p-12 novel-px-8 sm:novel-px-12 novel-text-base novel-leading-normal;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体に font-size: 16px と line-height: 180% を追加

theme: {
extend: {
lineHeight: {
normal: '180%',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lineheight をいじって 180% にするように

Comment on lines +135 to +148
.ProseMirror h1 {
font-size: 1.5rem;
font-weight: 600;
}

.ProseMirror h2 {
font-size: 1.25rem;
font-weight: 600;
}

.ProseMirror h3 {
font-size: 1.125rem;
font-weight: 600;
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading のスタイルを上書き

Copy link
Collaborator

@enokids enokids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます〜〜😭
LGTM!!

Copy link
Collaborator

@kenfdev kenfdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@kenfdev kenfdev merged commit 1d9d541 into she-main Jan 18, 2024
@kenfdev kenfdev deleted the feature/fix-style branch January 18, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants