Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare minor release (1.5.1) #74

Closed
wrycu opened this issue Oct 14, 2019 · 15 comments
Closed

prepare minor release (1.5.1) #74

wrycu opened this issue Oct 14, 2019 · 15 comments
Assignees
Labels
enhancement New feature or request low

Comments

@wrycu
Copy link
Collaborator

wrycu commented Oct 14, 2019

@Khopa has a lot of changes staged; getting them to a stable version where everything WIP is done may take a while. In the mean time, I'll prepare a minor bump with the following features:

Stretch goal:

@wrycu wrycu added enhancement New feature or request low labels Oct 14, 2019
wrycu referenced this issue Oct 14, 2019
* F-14B INS alignment pre-stored
* F-16C support
* requirements.txt for installing dependencies
@jayrook
Copy link

jayrook commented Oct 15, 2019

How do you use this? Sorry, I really am quite clueless when it comes to this sort of thing.

@Khopa
Copy link
Collaborator

Khopa commented Oct 16, 2019

@jayrook
There is no release yet, but you can run from source code if you want.

So if you don't want to wait, you can clone or download the repository on master branch, and follow the dev guide : https://github.com/shdwp/dcs_liberation/wiki/Development-guide

@jayrook
Copy link

jayrook commented Oct 16, 2019

Thanks!

wrycu pushed a commit that referenced this issue Oct 17, 2019
* display weather while selecting aircraft (#19)
wrycu pushed a commit that referenced this issue Oct 17, 2019
* correct weather generation (#19)
wrycu pushed a commit that referenced this issue Oct 17, 2019
@wrycu
Copy link
Collaborator Author

wrycu commented Oct 17, 2019

Okay, I'll try to get the build together tomorrow. If anyone could try out the Viper before then, that'd be great (I don't own it.)

@wrycu wrycu self-assigned this Oct 17, 2019
@Khopa
Copy link
Collaborator

Khopa commented Oct 17, 2019

I had a quick look, I get the following error when clicking proceed :

Traceback (most recent call last):
File "D:\Software\Python37\lib\tkinter_init_.py", line 1702, in call
return self.func(*args)
File "C:\Users\Clement\Desktop\dcs_liberation-master\ui\eventmenu.py", line 226, in start
self.game.initiate_event(self.event)
File "C:\Users\Clement\Desktop\dcs_liberation-master\game\game.py", line 245, in initiate_event
event.generate()
File "C:\Users\Clement\Desktop\dcs_liberation-master\game\event\event.py", line 117, in generate
self.operation.generate()
File "C:\Users\Clement\Desktop\dcs_liberation-master\game\operation\frontlineattack.py", line 56, in generate
self.airgen.generate_cas_strikegroup(*assigned_units_split(planes_flights), at=self.attackers_starting_position)
File "C:\Users\Clement\Desktop\dcs_liberation-master\gen\aircraft.py", line 289, in generate_cas_strikegroup
at=at and at or self._group_point(self.conflict.air_attackers_location))
File "C:\Users\Clement\Desktop\dcs_liberation-master\gen\aircraft.py", line 212, in _generate_group
return self._generate_inflight(name, side, unit_type, count, client_count, at.position)
File "C:\Users\Clement\Desktop\dcs_liberation-master\gen\aircraft.py", line 173, in _generate_inflight
group_size=count)
File "D:\Software\Python37\lib\site-packages\dcs\mission.py", line 1153, in flight_group
position, altitude, speed, maintask, group_size)
File "D:\Software\Python37\lib\site-packages\dcs\mission.py", line 1004, in flight_group_inflight
p = self.aircraft(name + " Pilot #{nr}".format(nr=i), aircraft_type, country)
File "D:\Software\Python37\lib\site-packages\dcs\mission.py", line 841, in aircraft
return Plane(self.next_unit_id(), self.string(name), _type, country)
File "D:\Software\Python37\lib\site-packages\dcs\unit.py", line 218, in init
super(Plane, self).init(_id, name, _type, _country)
File "D:\Software\Python37\lib\site-packages\dcs\unit.py", line 76, in init
self.livery_id = self.unit_type.default_livery(_country.name)
File "D:\Software\Python37\lib\site-packages\dcs\unittype.py", line 163, in default_livery
liveries = cls.Liveries
AttributeError: type object 'F_16C_50' has no attribute 'Liveries'

This is because the F16C has no Liveries, which cause a bug in pydcs when trying to use the aircraft.
I imported manually one of my fix from qt_ui branch in master :

class DefaultLiveries:
    class Default(Enum):
        af_standard = ""

OH_58D.Liveries = DefaultLiveries
F_16C_50.Liveries = DefaultLiveries
P_51D_30_NA.Liveries = DefaultLiveries

I added this at the beginning of db.py which prevent the issue from occuring for the aircraft type missing liveries options, this is just injecting a blank field for liveries (and it doesn't cause issues in DCS).

@wrycu
Copy link
Collaborator Author

wrycu commented Oct 18, 2019

As I mentioned in the discord, you'll need to update pydcs (pip install -r requirements.txt --upgrade.) Can you do that and let me know if you still get errors?

@Khopa
Copy link
Collaborator

Khopa commented Oct 18, 2019

I don't have blocking errors after my fix.
My pydcs version is already the latest from the pydcs repo.

(Even with latest release from pydcs, there are errors with the Viper if you don't do that, because it is missing liveries options in game for now, and pydcs doesn't seem to like that)

@ShiroSpectre
Copy link

Hey wrycu, hey khopa,
Is there a problem with the 1.51 release?

@wrycu
Copy link
Collaborator Author

wrycu commented Oct 30, 2019

This is my first time, so I had to figure out how to do it. I've cut a test release and sent it to the dev team on our Discord for testing. Once they've gotten back to me with a confirmation that it doesn't crash horribly, I'll add it as a release here.

@ShiroSpectre
Copy link

ShiroSpectre commented Oct 30, 2019

It was a pain to make my first release. Thank you for the update. Good luck with testing.

If I find the time, I‘ll give the master branch a try.

@wrycu
Copy link
Collaborator Author

wrycu commented Nov 9, 2019

Made another test release and sent it. If I get the okay from the other devs, I'll make it public.

@wrycu
Copy link
Collaborator Author

wrycu commented Nov 19, 2019

https://drive.google.com/open?id=1RE4jZyXKEp_vExFY649skCYJYbhjNe7m Please test and let me know if you see any issues. If someone ACKs back with no issues, I'll make it an actual release.

@ShiroSpectre
Copy link

Hey @wrycu ,
google is blocking the download, quite likely because there is a bat file in it. Maybe you can upload it on github and mark it as a testrelease?

@Khopa
Copy link
Collaborator

Khopa commented Nov 21, 2019

I have had this issue as well, i'm not able to download this pre-release on Google Drive either.

@wrycu wrycu changed the title prepare minor release (1.51) prepare minor release (1.5.1) Nov 22, 2019
@wrycu
Copy link
Collaborator Author

wrycu commented Nov 22, 2019

Created a new release. Please provide feedback on the Discord or via new issues.

@wrycu wrycu closed this as completed Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low
Projects
None yet
Development

No branches or pull requests

4 participants