Feature predefined and environment variables in config #655
Conversation
Adds support for predefined VS Code variable "${workspaceFolder}" to setting "configPath" in MPE.
This allows for configuring MPE per-workspace if needed.
fixes shd101wyy#625
setting "configPath" does not support environment variables.
Extended to support windows style %ENV_VAR% as well as bash style ${ENV_VAR} and $ENV_VAR environment variables
fixes shd101wyy#625
Implementation only applies to configPath and polutes the code. Refactors that code and extracts it into a PathResolver class. fixes shd101wyy#625
There was a problem hiding this comment.
Thanks! I approved it.
If I remember correctly there will be some issue if we use env variables but I don't recall what the issue is. So I will just approve it for now.
It would be great if the function names could be camel case. But it's okay for now 👍
I will merge your pull request 👍
From what I can see: possible solution: ignore any set configPath in this case and revert to default. Upon change of circumstances - e.g. loading of workspace - reiterate configuration steps.
oh damn... was working on another project in parallel. Must have used the naming convention from that project instead. 😒 Will correct it next time around. 😅 |
adds support for:
in setting "configPath"
fixes #625