Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsx bracket same line and parcel example build #535

Merged
merged 3 commits into from
Sep 25, 2021

Conversation

shawnmcknight
Copy link
Owner

Description 📝

This PR updates the prettier configuration to switch from jsxBracketSameLine (deprecated) to bracketSameLine. Additionally, the example bundled into the repo was updated to use <script type="module"... to ensure that parcel runs the example properly.

Type of change 💎

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist 🏁

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • My changes pass lint, prettier, and TS checks
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas

@shawnmcknight shawnmcknight merged commit 6c18288 into main Sep 25, 2021
@shawnmcknight shawnmcknight deleted the fix-jsxBracketSameLine branch September 25, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant