Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 630 export user tree colours #645

Merged
merged 56 commits into from
Feb 21, 2017

Conversation

LukedFitzpatrick
Copy link
Collaborator

Add export colour functionality after multiselect colour select.

Also adds a larger framework for Nexus bootstrap values (importing, exporting, export exclusions) which can be applied to #503.

Make sure colour branch doesn't fall behind master development.
Will eventually be added to each tree node, used initially to hold user defined colours.

Updates #630
…to the bootstrap block before export.

Updates #630
@shawnlaffan
Copy link
Owner

Merger is pending additional items uncovered by commits in this PR. These are in the to do list under issue #630

LukedFitzpatrick and others added 25 commits February 14, 2017 10:17
… Also update tests for bootstrap block to reflect change.

Updates #630
…weaks to bootstrap block encoding/decoding.

Updates #630
And avoid warnings/failures on recent perls.
Also some style changes and minor inefficiencies.

Updates #630
# Conflicts:
#	.travis.yml
#	lib/Biodiverse/Config.pm
#	lib/Biodiverse/GUI/Export.pm
#	lib/Biodiverse/Tree.pm
#	t/13-Tree.t
Also remove exclusions blocks

Updates #630
The subhash makes the logic cleaner when wrangling colours and the like.
It also means we can have a label if appropriate.

Updates #630
This currently fails as the parser assumes json compatible strings
(which is a false assumption on my part)

[ci skip]

Updates #630
Might make a difference when parsing very large trees

Updates #630
They can be worked on under issue #657

Updates #630
It can be dealt with under #657

Updates #630
Otherwise they were appearing in the GUI.

Minor tweaks to methods otherwise.

Updates #630
@shawnlaffan shawnlaffan merged commit db05ce2 into master Feb 21, 2017
@shawnlaffan shawnlaffan deleted the issue_630_export_user_tree_colours branch February 21, 2017 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants