Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when cluster analysis attempted for basedata with single group (cell) #782

Closed
shawnlaffan opened this issue Jan 6, 2021 · 1 comment
Closed

Warn when cluster analysis attempted for basedata with single group (cell) #782

shawnlaffan opened this issue Jan 6, 2021 · 1 comment
Assignees
@shawnlaffan
Labels
enhancement
Milestone
Release_4.0

Comments

@shawnlaffan
Copy link
Owner

Clustering a basedata with a single cell gives the cryptic error message of "No valid results - matrix is empty".

It should instead warn the user that cluster analyses cannot be run for such data.

Related to #781
@shawnlaffan shawnlaffan added this to the Release_4.0 milestone Jan 6, 2021
@shawnlaffan shawnlaffan self-assigned this Jan 6, 2021
shawnlaffan added a commit that referenced this issue Jan 20, 2021
@shawnlaffan
Throw exception when tree based analysis is added to single cell base…
c0eda3b 
…data

Updates #782
shawnlaffan added a commit that referenced this issue Jan 20, 2021
@shawnlaffan
Single cell basedatas: Add a warning message to the default name
df3dde9 
Updates #782
@shawnlaffan shawnlaffan changed the title Cluster analyses fail with single cell Warn when cluster analyses attempted for basedata with single cell Jan 20, 2021
@shawnlaffan shawnlaffan changed the title Warn when cluster analyses attempted for basedata with single cell Warn when cluster analysis attempted for basedata with single cell Jan 20, 2021
@shawnlaffan
Copy link
Owner Author

Mark as fixed.

There might be some scenarios where we should allow the clustering to proceed with a single group, for example automated systems using pre-coded workflows that can end up with single cell basedatas. In such cases we could simply return a tree comprising the group as the root node.
If it is ever needed then it can be revisited, or listed as a new issue.

@shawnlaffan shawnlaffan changed the title Warn when cluster analysis attempted for basedata with single cell Warn when cluster analysis attempted for basedata with single group (cell) Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
enhancement
Projects
None yet
Milestone
Release_4.0
Development

No branches or pull requests
1 participant
@shawnlaffan