Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group properties - simplify import process #761

Closed
8 tasks done
shawnlaffan opened this issue May 21, 2020 · 1 comment
Closed
8 tasks done

Group properties - simplify import process #761

shawnlaffan opened this issue May 21, 2020 · 1 comment
Assignees
Milestone

Comments

@shawnlaffan
Copy link
Owner

shawnlaffan commented May 21, 2020

Attaching group properties can be a cumbersome process.

Data are imported as a basedata, stats calculated, results exported to CSV, and then attached.

This can be done in a single pass, optionally adding the interim basedatas to the project when under the GUI.

To do:

  • Basic code
  • GUI
  • Add basedatas to project
  • Handle duplicate names - or just overwrite as that's simpler. Update: We overwrite as that's consistent with other property methods where duplicates are encountered.
  • Check extents match. Users might try data with different coordinate systems that cannot overlap. Warn if one or two mismatches, croak if many. Edit: make it configurable as a boolean arg
  • Use a def query to speed up analyses. Target basedata might be a very small subset of the property raster, for example global data from Worldclim being applied to a basedata of Indonesian plants. Def query can be the intersection of the extents. Moved to separate issue in raster imports: Use a def query to constrain imports #805
  • Throw exceptions on non-raster files - needs tests
  • Blog post - https://biodiverse-analysis-software.blogspot.com/2022/05/importing-group-properties-directly.html
@shawnlaffan shawnlaffan added this to the Release_4.0 milestone May 21, 2020
@shawnlaffan shawnlaffan self-assigned this May 21, 2020
shawnlaffan added a commit that referenced this issue Jul 25, 2021
shawnlaffan added a commit that referenced this issue Jul 25, 2021
shawnlaffan added a commit that referenced this issue Jul 25, 2021
shawnlaffan added a commit that referenced this issue Jul 25, 2021
shawnlaffan added a commit that referenced this issue Apr 23, 2022
shawnlaffan added a commit that referenced this issue Apr 23, 2022
shawnlaffan added a commit that referenced this issue Apr 23, 2022
shawnlaffan added a commit that referenced this issue Apr 23, 2022
shawnlaffan added a commit that referenced this issue Apr 23, 2022
And include axis count in error messages
for when number of axes !=2

Updates #761
shawnlaffan added a commit that referenced this issue Apr 23, 2022
Optional, and turned off by default

Updates #761
shawnlaffan added a commit that referenced this issue Apr 23, 2022
We only care if there are not two axes,
and the error message now includes the
axis count.

Updates #761
shawnlaffan added a commit that referenced this issue Apr 23, 2022
Also add some tooltips to the checkbox text.

Updates #761
shawnlaffan added a commit that referenced this issue Apr 23, 2022
An exception was already raised so we just needed the test.

Updates #761
shawnlaffan added a commit that referenced this issue Apr 24, 2022
shawnlaffan added a commit that referenced this issue Apr 24, 2022
shawnlaffan added a commit that referenced this issue Apr 24, 2022
shawnlaffan added a commit that referenced this issue Apr 24, 2022
and generalise the GUI table generation

Updates #761
@shawnlaffan
Copy link
Owner Author

All tasks have been completed or hived off to their own issues. Mark as fixed.

shawnlaffan added a commit that referenced this issue Jul 6, 2022
Otherwise things would get out of synch when adding
the property rasters to the project.

A late update to #761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant