Skip to content

Commit

Permalink
Fix systemd restart counter label from state to name (prometheus#1393)
Browse files Browse the repository at this point in the history
Signed-off-by: Mark Knapp <mknapp@hudson-trading.com>
  • Loading branch information
mknapphrt authored and oblitorum committed Apr 9, 2024
1 parent 76df68f commit 37d7620
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@
### **Breaking changes**

* The netdev collector CLI argument `--collector.netdev.ignored-devices` was renamed to `--collector.netdev.device-blacklist` in order to conform with the systemd collector. #1279
* The label named `state` on `node_systemd_service_restart_total` metrics was changed to `name` to better describe the metric. #1393


### Changes

* [CHANGE] Add `--collector.netdev.device-whitelist`. #1279
* [FEATURE]
* [ENHANCEMENT]
* [BUGFIX] Renamed label `state` to `name` on `node_systemd_service_restart_total`. #1393

## 0.18.1 / 2019-06-04

Expand Down
2 changes: 1 addition & 1 deletion collector/systemd_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func NewSystemdCollector() (Collector, error) {
"Summary of systemd unit states", []string{"state"}, nil)
nRestartsDesc := prometheus.NewDesc(
prometheus.BuildFQName(namespace, subsystem, "service_restart_total"),
"Service unit count of Restart triggers", []string{"state"}, nil)
"Service unit count of Restart triggers", []string{"name"}, nil)
timerLastTriggerDesc := prometheus.NewDesc(
prometheus.BuildFQName(namespace, subsystem, "timer_last_trigger_seconds"),
"Seconds since epoch of last trigger.", []string{"name"}, nil)
Expand Down

0 comments on commit 37d7620

Please sign in to comment.