forked from mojaloop/central-settlement
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1945 shashi #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added handler to monitor topic-notification-event * Added handler to monitor topic-notification-event * Added more code to break out vars from the msg on the notification topic * Finalize code to break out vars from the msg on the notification topic * Restructured code in the handler * Renamed fulfill to fulfil * Added initial code in the Domain to update the DB * Added Knex version of SQL statement (Promise pending error still) * Added more knex statements for the changed SQL from Micheal * Fixed the bindings error * Fixed the bindings error again * Add facade and domain code * Added Error handling * Fixed index.js * Removed unwanted code * Updated the handler register unit test * Fixed inner select error that magically started to appear * Added the status parameter * Added code to unit test transferfulfil facade * Add more code to facade unit test * Add unit test for domain/index.js * Add unit test for domain/index.js * Added unit tests to the handler * Added more unit tests to transferfulfil handler * Full code coverage achieved on the transferfulfil handler * Removed unit test on facade. TBD later * updated dependancies * Changed the port in default.json * Resolved vulnerabilities * Made some depnedancy update changes * Resloved vulnerabilities * Increased codee coverage on branches to 100% for transferFulfil handler * Fixed issue with Knex * Added filter for OTC498 * Renamed functions as per code review request * Fixed function name chnages in the unit tests * Added changes to facade unit test * Added code review change as requested by Rajiv * Added Ignores for the failing unit test on the facade * Added ignores for failing test
* Added handler to monitor topic-notification-event * Added handler to monitor topic-notification-event * Added more code to break out vars from the msg on the notification topic * Finalize code to break out vars from the msg on the notification topic * Restructured code in the handler * Renamed fulfill to fulfil * Added initial code in the Domain to update the DB * Added Knex version of SQL statement (Promise pending error still) * Added more knex statements for the changed SQL from Micheal * Fixed the bindings error * Fixed the bindings error again * Add facade and domain code * Added Error handling * Fixed index.js * Removed unwanted code * Updated the handler register unit test * Fixed inner select error that magically started to appear * Added the status parameter * Added code to unit test transferfulfil facade * Add more code to facade unit test * Add unit test for domain/index.js * Add unit test for domain/index.js * Added unit tests to the handler * Added more unit tests to transferfulfil handler * Full code coverage achieved on the transferfulfil handler * Removed unit test on facade. TBD later * updated dependancies * Changed the port in default.json * Resolved vulnerabilities * Made some depnedancy update changes * Resloved vulnerabilities * Increased codee coverage on branches to 100% for transferFulfil handler * Fixed issue with Knex * Added filter for OTC498 * Renamed functions as per code review request * Fixed function name chnages in the unit tests * Added changes to facade unit test * Added code review change as requested by Rajiv * Added Ignores for the failing unit test on the facade * Added ignores for failing test * Added Config.yml chnges for Python 3 depnedancy * deleted apk -v --purge del py-pip line from config.yml
* Added handler to monitor topic-notification-event * Added handler to monitor topic-notification-event * Added more code to break out vars from the msg on the notification topic * Finalize code to break out vars from the msg on the notification topic * Restructured code in the handler * Renamed fulfill to fulfil * Added initial code in the Domain to update the DB * Added Knex version of SQL statement (Promise pending error still) * Added more knex statements for the changed SQL from Micheal * Fixed the bindings error * Fixed the bindings error again * Add facade and domain code * Added Error handling * Fixed index.js * Removed unwanted code * Updated the handler register unit test * Fixed inner select error that magically started to appear * Added the status parameter * Added code to unit test transferfulfil facade * Add more code to facade unit test * Add unit test for domain/index.js * Add unit test for domain/index.js * Added unit tests to the handler * Added more unit tests to transferfulfil handler * Full code coverage achieved on the transferfulfil handler * Removed unit test on facade. TBD later * updated dependancies * Changed the port in default.json * Resolved vulnerabilities * Made some depnedancy update changes * Resloved vulnerabilities * Increased codee coverage on branches to 100% for transferFulfil handler * Fixed issue with Knex * Added filter for OTC498 * Renamed functions as per code review request * Fixed function name chnages in the unit tests * Added changes to facade unit test * Added code review change as requested by Rajiv * Added Ignores for the failing unit test on the facade * Added ignores for failing test * Added Config.yml chnges for Python 3 depnedancy * deleted apk -v --purge del py-pip line from config.yml * Added missing | for command in config.yml
* Added handler to monitor topic-notification-event * Added handler to monitor topic-notification-event * Added more code to break out vars from the msg on the notification topic * Finalize code to break out vars from the msg on the notification topic * Restructured code in the handler * Renamed fulfill to fulfil * Added initial code in the Domain to update the DB * Added Knex version of SQL statement (Promise pending error still) * Added more knex statements for the changed SQL from Micheal * Fixed the bindings error * Fixed the bindings error again * Add facade and domain code * Added Error handling * Fixed index.js * Removed unwanted code * Updated the handler register unit test * Fixed inner select error that magically started to appear * Added the status parameter * Added code to unit test transferfulfil facade * Add more code to facade unit test * Add unit test for domain/index.js * Add unit test for domain/index.js * Added unit tests to the handler * Added more unit tests to transferfulfil handler * Full code coverage achieved on the transferfulfil handler * Removed unit test on facade. TBD later * updated dependancies * Changed the port in default.json * Resolved vulnerabilities * Made some depnedancy update changes * Resloved vulnerabilities * Increased codee coverage on branches to 100% for transferFulfil handler * Fixed issue with Knex * Added filter for OTC498 * Renamed functions as per code review request * Fixed function name chnages in the unit tests * Added changes to facade unit test * Added code review change as requested by Rajiv * Added Ignores for the failing unit test on the facade * Added ignores for failing test * Added Config.yml chnges for Python 3 depnedancy * deleted apk -v --purge del py-pip line from config.yml * Added missing | for command in config.yml * Added knex statement into settlement handlet facade and index * Added failure conditions * Added last code changes * Increased code coverage with unit tests * Pushed code coverage up to 100% for the added code * Updated dependancies * Removed dependency cache line in ci/config yaml * Added processing of transfer fulfil message * Updating integration test config * Added changes from Neals branch * Updated settlement integration tests to create settlement models before transfers * Update package.json withh --production switches Co-authored-by: Neal Donnan <neal.donnan@modusbox.com>
* Initial commit * Initial commit * Added get transaction object feature * Updated unit tests * Added get transaction object feature tests * Updated tests Co-authored-by: Neal Donnan <neal.donnan@modusbox.com>
…feature/OTC # Conflicts: # .circleci/config.yml # audit-resolve.json # package-lock.json # package.json
…tion tests to the latest.
…jaloop#314) * OTC-624: refactoring integration tests initial data setup * OTC-624 fixing and refactoring cleaning up * OTC-624 refactoring and cleaning up test setup * Ignoring package updates * OTC-624 reverting back merge conflict change * OTC-624 renamed scenario and fixing axios version * OTC-624 renamed folder due to order of tests
* Added transferParticipantStateChange to cli * Implemented name change transferParticipantStateChange to transfeSettlement * Added code to handlers/index.js to increase code coverage
Feature/fix table rename See merge request tips/tiger/central-settlement!319
Feature/script engine integration See merge request tips/tiger/central-settlement!320
Feature/otc 676 unit tests See merge request tips/tiger/central-settlement!321
Added missing export in facade See merge request tips/tiger/central-settlement!323
Feature/temp move of scripts See merge request tips/tiger/central-settlement!349
…seeds' # Conflicts: # test/unit/models/transferSettlement/facade.test.js
…e/OTC' Feature/otc841 add settled state to seeds See merge request tips/tiger/central-settlement!342
Move kubernetes service account configuration into same step as deployment See merge request tips/tiger/central-settlement!346
Added more clever way to load scripts See merge request tips/tiger/central-settlement!350
Bugfix settlement window content fix See merge request tips/tiger/central-settlement!351
…sting NET_DEBIT_CAP
…nto 'feature/OTC' Added check for liquidity check before calculating liquidity and adjusting NET_DEBIT_CAP See merge request tips/tiger/central-settlement!352
…nto 'feature/OTC' Added unit test for liquidity check See merge request tips/tiger/central-settlement!353
…indows to only add entries for ledgerAccountTypes linked to NET settlement models
Added filtering for settlementWindowContent when closing settlement windows to... See merge request tips/tiger/central-settlement!354
Conflicts: config/default.json package-lock.json package.json src/lib/config.js src/shared/plugins.js test/integration/settlementTransfer.test.js test/integration/settlement_deferred_net_scenario/settlementTransfer.test.js
integration tests fix
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.