-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xamarin Bluetooth Stack (and Adjustment) #146
Xamarin Bluetooth Stack (and Adjustment) #146
Conversation
First Pass over it
|
I added multi-targets for NET5 and NETSTANDARD21. Looks good so far. |
I added the repo. Copy your two or three examples meanwhile. I will work another day on proper permissions. |
@Berdsen Tell me when you are ready for review here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had time and did a full review pass as of now. There are some comments to address.
src/SharpBrick.PoweredUp.Mobile/SharpBrick.PoweredUp.Mobile.csproj
Outdated
Show resolved
Hide resolved
src/SharpBrick.PoweredUp.Mobile/XamarinPoweredUpBluetoothAdapter.cs
Outdated
Show resolved
Hide resolved
src/SharpBrick.PoweredUp.Mobile/XamarinPoweredUpBluetoothAdapter.cs
Outdated
Show resolved
Hide resolved
src/SharpBrick.PoweredUp.Mobile/XamarinPoweredUpBluetoothAdapter.cs
Outdated
Show resolved
Hide resolved
src/SharpBrick.PoweredUp.Mobile/XamarinPoweredUpBluetoothAdapter.cs
Outdated
Show resolved
Hide resolved
src/SharpBrick.PoweredUp.Mobile/XamarinPoweredUpBluetoothAdapter.cs
Outdated
Show resolved
Hide resolved
src/SharpBrick.PoweredUp.Mobile/XamarinPoweredUpBluetoothAdapter.cs
Outdated
Show resolved
Hide resolved
We will go the multi-targeting route if nothing crashes. |
So I extracted the Xamarin app tested the Xamarin implementation with locally build nugets. At least for my "Vernie" the examples work :) |
This will fix #69
As currently mentioned, you should take a look at the last commit.
All the language features remain for the PoweredUp library but the target framework changed.
Perhaps it might be enough for now and can be reworked later with .NET 6 which hopefully brings Desktop and Mobile together on the same base.
Furthermore I just could test it with Android for now. iOS might be a little bit harder, because it might be tricky to get the BT adress of the requested device. I'm currently checking on how I can test a iOS application to check if it will work.
A maintenance release might be a good option. But the other options will not be necessary duplicate implementations but just a different csproj file of the lib, reflecting the changes made in the last commit. And then two different sln files for each type of project. The rest could remain.