Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Linux build #185

Closed
wants to merge 6 commits into from
Closed

[WIP] Linux build #185

wants to merge 6 commits into from

Conversation

seif
Copy link
Member

@seif seif commented Jan 6, 2019

Couldn't build on linux otherwise. It still doesn't build, due to missing AssemblyVersion, but this moves us in the right direction.

@seif seif changed the title Fix casing of folder names [WIP] Linux build Jan 6, 2019
@seif
Copy link
Member Author

seif commented Jan 6, 2019

@Shatl a bunch of issues while trying to get this to run into linux, the main 2 so far are:
* multi targeting netstandard and net461 doesn't work on linux dotnet/sdk#826 do we need multi targeting? project built with net461 should be able to reference netstandard2.0.
* GitVersion crashes, not sure what is going on with it, I've disabled it and gone with default. Will figure out what is borken later.
* OpenCover doesn't support linux OpenCover/opencover#703 worth trying AltCover instead? This is what I'm stuck on at the moment.

@cd21h
Copy link

cd21h commented Jan 6, 2019

@seif Do you want to move whole build to Linux? We can have a hybrid build where code coverage and publish will run on Windows, while Linux build will just run unit-tests. In this case having hard-coded version on Linux builds should be enough. Do you have an idea how to do it with Appveyor ?

  • 4.6.1. can be removed, I have no objections.

  • GitVersion is needed for package publishing only.

@seif
Copy link
Member Author

seif commented Jan 7, 2019

@Shatl cool, I've created various smaller PRs that include things I discovered here.

#187 fixes the file name casing
#188 Update github sourcelink
#189 remove net461

I'm hoping to get the same build running on CI and locally, so preferably we would have the coverage tool that runs on multi platforms. Initially, just getting to a stage where i can dotnet build dotnet test successfully would be good

@seif
Copy link
Member Author

seif commented May 17, 2019

Closing this as the work has been done in other issues

@seif seif closed this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants