Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Miri tests including big endian #211

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Conversation

sharksforarms
Copy link
Owner

#209

Tests fail on big endian :(

@sharksforarms
Copy link
Owner Author

sharksforarms commented May 11, 2021

May just be the way the tests are written? TestPrimitive!(test_u16, u16, vec![0xABu8, 0xCD], 0xCDAB /* < expected value depends on endianess */);

Edit: fixed this, created a macro to change the expected value based on target endian

@sharksforarms
Copy link
Owner Author

Nightly fails because of: rust-lang/rust#83079

@sharksforarms sharksforarms force-pushed the issue-209-test-big-endian branch 2 times, most recently from cd95de5 to dabc868 Compare June 15, 2021 15:47
@sharksforarms sharksforarms merged commit 23db7c4 into master Jun 15, 2021
@sharksforarms sharksforarms deleted the issue-209-test-big-endian branch June 15, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant