Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KColorChooser as supported tool #79

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

data-man
Copy link
Contributor

@data-man data-man commented Aug 29, 2019

No description provided.

@sharkdp
Copy link
Owner

sharkdp commented Aug 29, 2019

Thank you very much for your contribution.

I initially chose to omit KColorChooser because there is apparently no command-line switch to go into "Pick Screen Color" mode directly. All the other tools just directly show a (crosshair) cursor to pick a color from the screen.

It might still be a good idea to provide KColorChooser as a fall-back (because I imagine there is a large group of users that have it pre-installed).

What do you think?

@data-man
Copy link
Contributor Author

I'm KDE user, so I have no other color pickers. :)

@sharkdp
Copy link
Owner

sharkdp commented Aug 29, 2019

Ok, thanks. It's probably better than having none at all 😄

@sharkdp sharkdp merged commit 012529a into sharkdp:master Aug 29, 2019
@sharkdp
Copy link
Owner

sharkdp commented Sep 19, 2019

Released in v0.6.0.

@data-man
Copy link
Contributor Author

data-man commented Sep 20, 2019

@sharkdp
Would be nice to allow the user to select a specific color chooser if there are several of them installed.

@sharkdp
Copy link
Owner

sharkdp commented Sep 20, 2019

Can you please open a new ticket for this request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants