Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for transparency #162
feat: add support for transparency #162
Changes from all commits
c92b093
d536258
1e480f0
4a33aca
c92072c
a8b209c
c5aba8d
abd0b3f
74c9ec7
dae9309
5be38d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I think this should provide proper coverage. This asserts that:
00
-fe
)rgba()
, with alpha as decimalFor example,
#00000080
parses to a color that stringifies torgba(0, 0, 0, 0.502)
, that in turn parses to a color that stringifies to#00000080
. This actually caught a bug, where I was outputting alpha hex values using(f64 * 255.) as u8
, when I should have been using(f64 * 255.).round() as u8
.I also threw in an
impl FromStr for Color
that callsparser::parse_color
, that's not required, just thought it may be useful.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!