Add combinator parsing to parser.rs #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfbro
force-pushed
the
combinator-parsing
branch
from
be4870f to
ea49234
Compare
|
Thank you very much for your contribution. This is a bit hard to review, since you also refactored the test cases (which is probably a good thing, haven't looked at it in detail). I am assuming that you did not delete or alter any test cases? |
|
Any update on this? |
|
I re-instated the removed tests (I don't really understand why they were removed). I also added a simple benchmark which shows that this new implementation is significantly faster 👍
|
|
@halfbro Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #12
This PR adds combinator-based parsing using nom.
This allows the code to uniformly handle numerics (percentages, decimals, integers), and can also eventually provide error output in case of parser failure (not implemented yet).
I haven't had a chance to benchmark the differences between the parsers yet.