Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple color stops for gradients #104

Merged
merged 2 commits into from
Oct 13, 2019
Merged

Add multiple color stops for gradients #104

merged 2 commits into from
Oct 13, 2019

Conversation

felipe-fg
Copy link
Contributor

Add support for color scales and gradients with multiple colors at different positions.

Closes #49.

sharkdp
sharkdp reviewed Oct 13, 2019
View reviewed changes
src/cli/cli.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Oct 13, 2019
View reviewed changes
src/cli/error.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Oct 13, 2019
View reviewed changes
src/lib.rs Show resolved Hide resolved
sharkdp
sharkdp reviewed Oct 13, 2019
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Oct 13, 2019
View reviewed changes
src/lib.rs Show resolved Hide resolved
sharkdp
sharkdp reviewed Oct 13, 2019
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Oct 13, 2019
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
sharkdp
sharkdp reviewed Oct 13, 2019
View reviewed changes
src/lib.rs Show resolved Hide resolved
sharkdp
sharkdp reviewed Oct 13, 2019
View reviewed changes
src/lib.rs Show resolved Hide resolved
sharkdp
sharkdp requested changes Oct 13, 2019
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

The code looks really great. I added a few inline comments above.

@felipe-fg
Copy link
Contributor Author

Hey, @sharkdp.

I've just pushed a new (ammed) commit to fix those issues.

sharkdp
sharkdp approved these changes Oct 13, 2019
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the updates!

@sharkdp sharkdp merged commit 4ec6719 into sharkdp:master Oct 13, 2019
@felipe-fg felipe-fg deleted the gradient-multiple-stops branch October 19, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add multiple stops for gradient command
2 participants
@felipe-fg @sharkdp