improve time option usage #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
reviewed
Sep 3, 2020
| @@ -411,7 +411,7 @@ pub fn build_app() -> App<'static, 'static> { | |||
| .arg( | |||
| Arg::with_name("changed-within") | |||
| .long("changed-within") | |||
| .alias("change-newer-than") | |||
There was a problem hiding this comment.
I think removing this alias isn't backwards compatible. Why not keep both aliases?
|
Thank you @tmccombs! |
tmccombs
approved these changes
Sep 10, 2020
|
@tmccombs Thank you for reviewing and merging this! Just a minor thing: It would be great if we can ask contributors to adapt the Something like: Could you please add an entry to the "unreleased" section in where I guess we should add this to a PR template or some contributing guide. |
|
Ok, I'll do that next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #624
Currently, aliases for fd's time option are not so memorable and we have to specify full timestamp.
So, I changed the aliases for time option into more memorable ones and default the time component to 00:00:00 when only a date is given