-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faded colors with solarized light? #1031
Comments
Can you paste the output of
where |
Thank you for the quick response. Here is the output:
***@***.*** pr-app % ls --color=always | xxd
00000000: 4c49 4345 4e53 450a 5245 4144 4d45 2e6d LICENSE.README.m
00000010: 640a 1b5b 3334 6d62 7569 6c64 1b5b 3339 d..[34mbuild.[39
00000020: 3b34 396d 1b5b 306d 0a62 7569 6c64 2e78 ;49m.[0m.build.x
00000030: 6d6c 0a63 6f6c 6c65 6374 696f 6e2e 7863 ml.collection.xc
00000040: 6f6e 660a 636f 6e74 726f 6c6c 6572 2e78 onf.controller.x
00000050: 716c 0a63 7970 7265 7373 2e6a 736f 6e0a ql.cypress.json.
00000060: 1b5b 3334 6d64 6174 611b 5b33 393b 3439 .[34mdata.[39;49
00000070: 6d1b 5b30 6d0a 1b5b 3334 6d64 6576 1b5b m.[0m..[34mdev.[
00000080: 3339 3b34 396d 1b5b 306d 0a65 7870 6174 39;49m.[0m.expat
00000090: 682d 706b 672e 786d 6c0a 6963 6f6e 2e70 h-pkg.xml.icon.p
000000a0: 6e67 0a1b 5b33 346d 6d6f 6475 6c65 731b ng..[34mmodules.
000000b0: 5b33 393b 3439 6d1b 5b30 6d0a 7061 636b [39;49m.[0m.pack
000000c0: 6167 652d 6c6f 636b 2e6a 736f 6e0a 7061 age-lock.json.pa
000000d0: 636b 6167 652e 6a73 6f6e 0a70 6f73 742d ckage.json.post-
000000e0: 696e 7374 616c 6c2e 7871 6c0a 1b5b 3334 install.xql..[34
000000f0: 6d70 722d 6170 702d 7475 746f 7269 616c mpr-app-tutorial
00000100: 731b 5b33 393b 3439 6d1b 5b30 6d0a 7072 s.[39;49m.[0m.pr
00000110: 2d61 7070 2e63 6f64 652d 776f 726b 7370 -app.code-worksp
00000120: 6163 650a 1b5b 3331 6d70 7265 2d69 6e73 ace..[31mpre-ins
00000130: 7461 6c6c 2e78 716c 1b5b 3339 3b34 396d tall.xql.[39;49m
00000140: 1b5b 306d 0a72 6570 6f2e 786d 6c0a 1b5b .[0m.repo.xml..[
00000150: 3334 6d72 6573 6f75 7263 6573 1b5b 3339 34mresources.[39
00000160: 3b34 396d 1b5b 306d 0a1b 5b33 346d 7370 ;49m.[0m..[34msp
00000170: 7269 6e74 5f72 6570 6f72 7473 1b5b 3339 rint_reports.[39
00000180: 3b34 396d 1b5b 306d 0a1b 5b33 346d 7465 ;49m.[0m..[34mte
00000190: 7374 1b5b 3339 3b34 396d 1b5b 306d 0a1b st.[39;49m.[0m..
000001a0: 5b33 346d 7465 7374 2d74 6d70 1b5b 3339 [34mtest-tmp.[39
000001b0: 3b34 396d 1b5b 306d 0a1b 5b33 346d 7669 ;49m.[0m..[34mvi
000001c0: 6577 731b 5b33 393b 3439 6d1b 5b30 6d0a ews.[39;49m.[0m.
***@***.*** pr-app % fd --color=always -d 1 | xxd
00000000: 1b5b 3338 3b35 3b38 316d 2e2f 1b5b 306d .[38;5;81m./.[0m
00000010: 1b5b 3338 3b35 3b32 3439 6d4c 4943 454e .[38;5;249mLICEN
00000020: 5345 1b5b 306d 0a1b 5b33 383b 353b 3831 SE.[0m..[38;5;81
00000030: 6d2e 2f1b 5b30 6d1b 5b34 383b 353b 3138 m./.[0m.[48;5;18
00000040: 363b 3338 3b35 3b31 366d 5245 4144 4d45 6;38;5;16mREADME
00000050: 2e6d 641b 5b30 6d0a 1b5b 3338 3b35 3b38 .md.[0m..[38;5;8
00000060: 316d 2e2f 1b5b 306d 6275 696c 642e 786d 1m./.[0mbuild.xm
00000070: 6c0a 1b5b 3338 3b35 3b38 316d 2e2f 1b5b l..[38;5;81m./.[
00000080: 306d 636f 6c6c 6563 7469 6f6e 2e78 636f 0mcollection.xco
00000090: 6e66 0a1b 5b33 383b 353b 3831 6d2e 2f1b nf..[38;5;81m./.
000000a0: 5b30 6d63 6f6e 7472 6f6c 6c65 722e 7871 [0mcontroller.xq
000000b0: 6c0a 1b5b 3338 3b35 3b38 316d 2e2f 1b5b l..[38;5;81m./.[
000000c0: 306d 1b5b 3338 3b35 3b31 3439 6d63 7970 0m.[38;5;149mcyp
000000d0: 7265 7373 2e6a 736f 6e1b 5b30 6d0a 1b5b ress.json.[0m..[
000000e0: 3338 3b35 3b38 316d 2e2f 1b5b 306d 1b5b 38;5;81m./.[0m.[
000000f0: 3338 3b35 3b38 316d 6461 7461 1b5b 306d 38;5;81mdata.[0m
00000100: 1b5b 3338 3b35 3b38 316d 2f1b 5b30 6d0a .[38;5;81m/.[0m.
00000110: 1b5b 3338 3b35 3b38 316d 2e2f 1b5b 306d .[38;5;81m./.[0m
00000120: 1b5b 3338 3b35 3b38 316d 6465 761b 5b30 .[38;5;81mdev.[0
00000130: 6d1b 5b33 383b 353b 3831 6d2f 1b5b 306d m.[38;5;81m/.[0m
00000140: 0a1b 5b33 383b 353b 3831 6d2e 2f1b 5b30 ..[38;5;81m./.[0
00000150: 6d65 7870 6174 682d 706b 672e 786d 6c0a mexpath-pkg.xml.
00000160: 1b5b 3338 3b35 3b38 316d 2e2f 1b5b 306d .[38;5;81m./.[0m
00000170: 1b5b 3338 3b35 3b32 3038 6d69 636f 6e2e .[38;5;208micon.
00000180: 706e 671b 5b30 6d0a 1b5b 3338 3b35 3b38 png.[0m..[38;5;8
00000190: 316d 2e2f 1b5b 306d 1b5b 3338 3b35 3b38 1m./.[0m.[38;5;8
000001a0: 316d 6d6f 6475 6c65 731b 5b30 6d1b 5b33 1mmodules.[0m.[3
000001b0: 383b 353b 3831 6d2f 1b5b 306d 0a1b 5b33 8;5;81m/.[0m..[3
000001c0: 383b 353b 3831 6d2e 2f1b 5b30 6d1b 5b33 8;5;81m./.[0m.[3
000001d0: 383b 353b 3234 336d 7061 636b 6167 652d 8;5;243mpackage-
000001e0: 6c6f 636b 2e6a 736f 6e1b 5b30 6d0a 1b5b lock.json.[0m..[
000001f0: 3338 3b35 3b38 316d 2e2f 1b5b 306d 1b5b 38;5;81m./.[0m.[
00000200: 3338 3b35 3b31 3439 6d70 6163 6b61 6765 38;5;149mpackage
00000210: 2e6a 736f 6e1b 5b30 6d0a 1b5b 3338 3b35 .json.[0m..[38;5
00000220: 3b38 316d 2e2f 1b5b 306d 706f 7374 2d69 ;81m./.[0mpost-i
00000230: 6e73 7461 6c6c 2e78 716c 0a1b 5b33 383b nstall.xql..[38;
00000240: 353b 3831 6d2e 2f1b 5b30 6d1b 5b33 383b 5;81m./.[0m.[38;
00000250: 353b 3831 6d70 722d 6170 702d 7475 746f 5;81mpr-app-tuto
00000260: 7269 616c 731b 5b30 6d1b 5b33 383b 353b rials.[0m.[38;5;
00000270: 3831 6d2f 1b5b 306d 0a1b 5b33 383b 353b 81m/.[0m..[38;5;
00000280: 3831 6d2e 2f1b 5b30 6d1b 5b31 3b33 383b 81m./.[0m.[1;38;
00000290: 353b 3230 336d 7072 652d 696e 7374 616c 5;203mpre-instal
000002a0: 6c2e 7871 6c1b 5b30 6d0a 1b5b 3338 3b35 l.xql.[0m..[38;5
000002b0: 3b38 316d 2e2f 1b5b 306d 7265 706f 2e78 ;81m./.[0mrepo.x
000002c0: 6d6c 0a1b 5b33 383b 353b 3831 6d2e 2f1b ml..[38;5;81m./.
000002d0: 5b30 6d1b 5b33 383b 353b 3831 6d72 6573 [0m.[38;5;81mres
000002e0: 6f75 7263 6573 1b5b 306d 1b5b 3338 3b35 ources.[0m.[38;5
000002f0: 3b38 316d 2f1b 5b30 6d0a 1b5b 3338 3b35 ;81m/.[0m..[38;5
00000300: 3b38 316d 2e2f 1b5b 306d 1b5b 3338 3b35 ;81m./.[0m.[38;5
00000310: 3b38 316d 7370 7269 6e74 5f72 6570 6f72 ;81msprint_repor
00000320: 7473 1b5b 306d 1b5b 3338 3b35 3b38 316d ts.[0m.[38;5;81m
00000330: 2f1b 5b30 6d0a 1b5b 3338 3b35 3b38 316d /.[0m..[38;5;81m
00000340: 2e2f 1b5b 306d 1b5b 3338 3b35 3b38 316d ./.[0m.[38;5;81m
00000350: 7465 7374 1b5b 306d 1b5b 3338 3b35 3b38 test.[0m.[38;5;8
00000360: 316d 2f1b 5b30 6d0a 1b5b 3338 3b35 3b38 1m/.[0m..[38;5;8
00000370: 316d 2e2f 1b5b 306d 1b5b 3338 3b35 3b38 1m./.[0m.[38;5;8
00000380: 316d 7465 7374 2d74 6d70 1b5b 306d 1b5b 1mtest-tmp.[0m.[
00000390: 3338 3b35 3b38 316d 2f1b 5b30 6d0a 1b5b 38;5;81m/.[0m..[
000003a0: 3338 3b35 3b38 316d 2e2f 1b5b 306d 1b5b 38;5;81m./.[0m.[
000003b0: 3338 3b35 3b38 316d 7669 6577 731b 5b30 38;5;81mviews.[0
000003c0: 6d1b 5b33 383b 353b 3831 6d2f 1b5b 306d m.[38;5;81m/.[0m
000003d0: 0a .
…On Sun, Jun 5, 2022 at 6:57 PM Tavian Barnes ***@***.***> wrote:
Can you paste the output of
$ ls --color=always path/to/file | xxd
$ fd --color=always -p path/to/file | xxd
where path/to/file is a file with different colors for ls and fd?
—
Reply to this email directly, view it on GitHub
<#1031 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPRXXD3DWPH6EVPK4CHNKDVNUWGFANCNFSM5X5IGOAA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Ah I forgot |
@tavianator I set
|
Do you mind trying it with both Also, can you paste the value of the |
In the first tests below, I'm in a
Apparently regular files are not colored by
|
Ah okay, I see. What's happening is that most terminal emulators use the "intense" color palette when rendering bold text. But the Solarized Light "intense" colors are pretty monochrome (except for red, for some reason). You can use the 256-color escape sequence instead to force it to use the regular palette: Here's a Konsole bug about this, btw: https://bugs.kde.org/show_bug.cgi?id=405345. Looking back at your original post, what if you uncheck "Brighten bold text"? |
^ The above comment is relevant to the In the meantime, you can use something like vivid to generate an LS_COLORS theme that will look better with your terminal theme. For example: |
@tavianator I'm using the default (MacOS, that is, BSD, I guess) With There is still a difference in the way
This isn't a problem that necessarily requires a solution. Your description of the original issue as originating in a default behavior with unset |
Right, I should have guessed this from "iterm2" :)
Yeah, that's expected.
You're welcome! :) I'm going to leave this open because I do think we should consider changing the default color scheme to work okay with light terminal themes. @sharkdp how about |
You mean.. for both dark and light background themes? We have a similar problem in |
Is there a way to do this that works on all (or most) platforms? |
Yeah.
However, there are some other ways to get that information. Some terminals support a But the best way is probably the The syntax comes from X11's |
|
Hm. Are we sure there are no downsides to this? Like some runtime penalty. Or compatibility problems where some users would see seemingly random garbage on the screen? |
Well I read through the termbg implementation and it's not perfect, but conceptually it can be done without a delay and without the chance of users seeing garbage. I prototyped something but I'm not sure if I should publish it as it's own crate or contribute it to crossterm |
Same kind of issue on macOS Ventura with default macOS Terminal. Image: The Terminal app uses default white/light background. The When I export LS_COLORS='' then Expected: Actual: |
Would it be an option to make |
I also want to emphasize that this should be fixed instead of leaving it up to the user to add It's also noteworthy that setting So to make export EXA_COLORS="$LS_COLORS"
export LS_COLORS='' |
this is not only broken with solarized, but with gnome white background terminal as well. fd makes a difference if LS_COLORS is set to empty string, and not set. |
What version of
fd
are you using?fd 8.2.1
In iterm2 (Build 3.4.15)
fd
renders several colors in pale pastel hues that cannot easily be read against the background because of insufficient contrast.ls -G
does not have this issue. My iterm2 settings are:LS_COLORS is not set.
I'm not wedded to "Light (High Contrast)" or "Solarized light", but my vision is imperfect and I can't read the screen with dark themes, so I do need something light (but not a bright white background) with strong colors and strong color contrasts. I don't have this issue with any other application that produces colored text output in iterm2. Are there iterm2 settings or
fd
options that would enable me to render output fromfd
that is no less legible than the output oflg -G
?The text was updated successfully, but these errors were encountered: