Styleguide #2030
Merged
Styleguide #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mporkola
commented
May 11, 2016
•
mporkola
commented
- basic Storybook setup
- colors and typography
- existing components (?)
mporkola
force-pushed
the
styleguide
branch
2 times, most recently
from
7d21a80
to
c8c1ff6
Compare
|
|
||
| a { | ||
| text-decoration: none; | ||
| } |
|
I really think that having a view with all the components would be essential and the current Storybook setup doesn't provide that. Would it be possible to add that? |
| r(OnboardingTopBar, Object.assign({}, defaultProps, { | ||
| progress: 0, | ||
| next_step: 'slogan_and_description', | ||
| })))) |
There was a problem hiding this comment.
We could perhaps create some helper functions that essentially print props here.
Something like:
.add('Not started', () => (
div([
div({ className: css.showProps }, JSON.stringify(defaultProps)),
r(OnboardingTopBar, Object.assign({}, defaultProps, {
progress: 0,
next_step: 'slogan_and_description',
}))
])))
(Although, json.stringify is a bit unreadable.)
| @@ -53,8 +53,7 @@ _webpack.client.rails.build.config.js_ defines how component specific styles are | |||
| We are using [CSS Modules](https://github.com/css-modules/css-modules) and preprocessors like SASS-loader and [PostCSS](https://github.com/postcss/postcss) loader. | |||
| **N.B. we are likely to remove SASS loader quite soon and configure PostCSS better.** | |||
|
|
|||
| Hot loading works in dev environment (see http://your-marketplace-ident.lvh.me:3000/styleguide), so you should add your components to styleguide too (folder: _sharetribe/app/views/styleguide/_). | |||
| Webpack hot loading server is configured by _webpack.client.rails.hot.config.js_ and _server-rails-hot.js_. | |||
| We use [React Stylebook](https://github.com/kadirahq/react-storybook) for a hot reloading component development environment, in `http://localhost:9001/`. See [instructions for writing stories](https://github.com/kadirahq/react-storybook#writing-stories), for example story see [OnboardingTopBar.story.js](app/components/OnboardingTopBar/OnboardingTopBar.story.js). | |||
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.