Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from CircleCI to Github Actions for tests and linting #6

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Migrate from CircleCI to Github Actions for tests and linting #6

merged 3 commits into from
Jun 13, 2022

Conversation

fsanggang
Copy link

@fsanggang fsanggang commented May 31, 2022 •
edited
Loading

📝 Description

Added GA workflows to run tests and run Rubocop linting.

@fsanggang fsanggang added test suite A PR strictly targeting our test suite or CI Ready for Code Review In the process of, or in need of, a Code Review labels May 31, 2022
@fsanggang fsanggang self-assigned this May 31, 2022
@sharesightcircleci
Copy link
Collaborator

Task linked: CU-2cx2bgp Migrate encrypted_strings from CircleCI to GA

@fsanggang fsanggang requested a review from alto May 31, 2022 23:29
This was referenced May 31, 2022
Merged
Merged
@fsanggang fsanggang added Progress / Don't Merge Anything WIP or not ready for a shared environment. and removed Ready for Code Review In the process of, or in need of, a Code Review labels Jun 2, 2022
@alto alto mentioned this pull request Jun 2, 2022
Merged
alto
alto approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@alto alto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM actually. I have added rubocop linting, maybe integrate?

@fsanggang fsanggang force-pushed the chore/migrate_to_github_actions branch from d9d89db to 0a1126a Compare June 9, 2022 04:33
@fsanggang fsanggang added gh-actions Pull requests with updates related to Github Actions. and removed Progress / Don't Merge Anything WIP or not ready for a shared environment. labels Jun 9, 2022
@fsanggang fsanggang changed the title Migrate from CircleCI to Github Actions for tests Migrate from CircleCI to Github Actions for tests and linting Jun 13, 2022
@fsanggang fsanggang merged commit 16ff87a into master Jun 13, 2022
@fsanggang fsanggang deleted the chore/migrate_to_github_actions branch June 13, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alto alto alto approved these changes

Assignees

@fsanggang fsanggang

Labels
gh-actions Pull requests with updates related to Github Actions. test suite A PR strictly targeting our test suite or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsanggang @sharesightcircleci @alto