Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds deep link configuration #85

Closed
wants to merge 2 commits into from

Conversation

PanchoBubble
Copy link
Contributor

@PanchoBubble PanchoBubble commented Jan 4, 2023

Android

<intent-filter> Requires the data tag in order to open the app via browser link
https://developer.android.com/training/app-links/deep-linking

iOS

Needs CFBundleURLSchemes in order to deep link
https://book.hacktricks.xyz/mobile-pentesting/ios-pentesting/ios-custom-uri-handlers-deeplinks-custom-schemes

These changes are required in order to open the app via a browser link in the following format

<a href="shapeshift://"> Open ShapeShift App </a>

@PanchoBubble PanchoBubble changed the title Adds <data> tag to intent filters manifest Adds <data> tag to intent filters manifest [Deep linking fix] Jan 4, 2023
@PanchoBubble PanchoBubble changed the title Adds <data> tag to intent filters manifest [Deep linking fix] Adds deep link configuration Jan 4, 2023
@cjthompson
Copy link
Contributor

I don't have a problem with this change. @0xdef1cafe or @0xean ?

@0xean
Copy link
Contributor

0xean commented Jan 25, 2023

@PanchoBubble - thanks for the PR, sorry I missed this until now and thanks @cjthompson for the ping. reviewing now

@0xdef1cafe
Copy link
Collaborator

closing in favor of #89

@0xdef1cafe 0xdef1cafe closed this Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants