Better support for initialisms in spice names #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now all uppercase characters are being treated as word boundaries, which is sub-optimal. It causes property names like "localURL" to become "Local U R L", necessitating overrides for all the properties. This new implementation keeps multiple uppercase characters together as a single word, and splits instead on the boundary where an uppercase character is introduced after a lowercase one. This does a better job of preserving initialisms, but doesn't properly handle initialisms at the start of the spice name. I'm not sure a great solution for that, so clients should just override those where appropriate.
simonbs
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves handling for multiple sequenced uppercase characters in spice names when formatting for display.
Motivation and Context
Right now all uppercase characters are being treated as word boundaries, which is sub-optimal. It causes property names like "localURL" to become "Local U R L", necessitating overrides for all the properties.
This new implementation keeps multiple uppercase characters together as a single word, and splits instead on the boundary where an uppercase character is introduced after a lowercase one.
This does a better job of preserving initialisms, but doesn't properly handle initialisms at the start of the spice name. I'm not sure a great solution for that, so clients should just override those where appropriate.
Types of changes