Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add @suppress {constantProperty} to shaka externs. (#8062) #8063

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

joeyparrish
Copy link
Member

@joeyparrish joeyparrish commented Feb 11, 2025

Add @suppress {constantProperty} to shaka externs.

Cherry-picked from v4.13.x, where the original PR was sent by mistake.

@joeyparrish joeyparrish requested a review from a team February 11, 2025 19:29
@avelad
Copy link
Member

avelad commented Feb 11, 2025

@joeyparrish please fix the lint error

@joeyparrish joeyparrish merged commit f9b347b into shaka-project:main Feb 11, 2025
16 of 17 checks passed
@joeyparrish joeyparrish deleted the suppress-constant branch February 11, 2025 19:38
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants