Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configuration to ignore SCTE214 supplemental codecs #7717

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 5, 2024

Based on the work of @gmcgarry Thank you very much!

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Dec 5, 2024
@avelad avelad added this to the v4.13 milestone Dec 5, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests!

@avelad
Copy link
Member Author

avelad commented Dec 5, 2024

Add tests!

Done!

@avelad avelad requested a review from tykus160 December 5, 2024 11:58
@avelad avelad merged commit e1d1d19 into shaka-project:main Dec 5, 2024
18 checks passed
@avelad avelad deleted the ignoreSupplementalCodecs branch December 5, 2024 14:40
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Feb 3, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants