-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide framerate and codecs information on video tracks #533
Changes from 6 commits
fb58b69
bc7afd0
4585e4f
89e8d66
a23ef4f
40c682b
10530ef
0f8aadc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,7 +107,7 @@ describe('DashParser.Manifest', function() { | |
], | ||
[ | ||
' <AdaptationSet contentType="video" mimeType="video/mp4"', | ||
' codecs="avc1.4d401f" lang="en">', | ||
' codecs="avc1.4d401f" frameRate="1000000/42000" lang="en">', | ||
' <Representation bandwidth="100" width="768" height="576" />', | ||
' <Representation bandwidth="50" width="576" height="432" />', | ||
' </AdaptationSet>', | ||
|
@@ -136,13 +136,15 @@ describe('DashParser.Manifest', function() { | |
.presentationTimeOffset(0) | ||
.mime('video/mp4', 'avc1.4d401f') | ||
.bandwidth(100) | ||
.frameRate(23.80952380952380952380) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The precision here is worrying. Are all of these digits required to get a match out of Jasmine? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be honest I haven't tested with a lower precision so I don't know if all of these digits are required There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did a test and it seems that Jasmine requires full precision here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, then. Please add a comment like: // TODO: get Jasmine to match with less precision And my team will work on it later. |
||
.size(768, 576) | ||
.addStream(jasmine.any(Number)) | ||
.anySegmentFunctions() | ||
.anyInitSegment() | ||
.presentationTimeOffset(0) | ||
.mime('video/mp4', 'avc1.4d401f') | ||
.bandwidth(50) | ||
.frameRate(23.80952380952380952380) | ||
.size(576, 432) | ||
.addStreamSet('text') | ||
.language('es') | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this match, Number(res[1]) is the same as Number(exprString), so I would just drop this else if completely.